refactor: change Notification prop name code to name type

Author: MartinCupela

src/messageComposer/attachmentManager.ts

@@ -386,7 +386,7 @@ export class AttachmentManager {
       this.client.notifications.addError({
         message: 'File is required for upload attachment',
         origin: { emitter: 'AttachmentManager', context: { attachment } },
-        options: { code: 'validation:attachment:file:missing' },
+        options: { type: 'validation:attachment:file:missing' },
       });
       return;
     }
@@ -458,7 +458,7 @@ export class AttachmentManager {
           context: { attachment, blockedAttachment: localAttachment },
         },
         options: {
-          code: 'validation:attachment:upload:blocked',
+          type: 'validation:attachment:upload:blocked',
           metadata: {
             reason: localAttachment.localMetadata.uploadPermissionCheck?.reason,
           },
@@ -497,7 +497,7 @@ export class AttachmentManager {
           context: { attachment, failedAttachment },
         },
         options: {
-          code: 'api:attachment:upload:failed',
+          type: 'api:attachment:upload:failed',
           metadata: { reason },
           originalError: error instanceof Error ? error : undefined,
         },

src/messageComposer/messageComposer.ts

@@ -675,7 +675,7 @@ export class MessageComposer extends WithSubscriptions {
           context: { composer: this },
         },
         options: {
-          code: 'api:poll:create:failed',
+          type: 'api:poll:create:failed',
           metadata: {
             reason: (error as Error).message,
           },

src/notifications/NotificationManager.ts

@@ -49,7 +49,7 @@ export class NotificationManager {
       id,
       message,
       origin,
-      code: options?.code,
+      type: options?.type,
       severity,
       createdAt: now,
       expiresAt: now + duration,

src/notifications/types.ts

@@ -78,7 +78,7 @@ export type Notification = {
    *   'system:internal:error'            // Internal system error
    *   'system:resource:unavailable';     // System resource unavailable
    */
-  code?: string;
+  type?: string;
   /** Optional timestamp when notification should expire */
   expiresAt?: number;
   /** Optional metadata to attach to the notification */
@@ -89,7 +89,7 @@ export type Notification = {
 
 /** Configuration options when creating a notification */
 export type NotificationOptions = Partial<
-  Pick<Notification, 'code' | 'severity' | 'actions' | 'metadata' | 'originalError'>
+  Pick<Notification, 'type' | 'severity' | 'actions' | 'metadata' | 'originalError'>
 > & {
   /** How long a notification should be displayed in milliseconds */
   duration?: number;

test/unit/MessageComposer/attachmentManager.test.ts

@@ -1048,7 +1048,7 @@ describe('AttachmentManager', () => {
           },
         },
         options: {
-          code: 'api:attachment:upload:failed',
+          type: 'api:attachment:upload:failed',
           metadata: { reason: 'Upload failed' },
           originalError: expect.any(Error),
         },
@@ -1089,7 +1089,7 @@ describe('AttachmentManager', () => {
           },
         },
         options: {
-          code: 'validation:attachment:upload:blocked',
+          type: 'validation:attachment:upload:blocked',
           metadata: { reason: 'size_limit' },
         },
       });
@@ -1168,7 +1168,7 @@ describe('AttachmentManager', () => {
       expect(mockClient.notifications.addError).toHaveBeenCalledWith({
         message: 'File is required for upload attachment',
         options: {
-          code: 'validation:attachment:file:missing',
+          type: 'validation:attachment:file:missing',
         },
         origin: {
           emitter: 'AttachmentManager',
@@ -1202,7 +1202,7 @@ describe('AttachmentManager', () => {
       expect(mockClient.notifications.addError).toHaveBeenCalledWith({
         message: 'File is required for upload attachment',
         options: {
-          code: 'validation:attachment:file:missing',
+          type: 'validation:attachment:file:missing',
         },
         origin: {
           emitter: 'AttachmentManager',

test/unit/MessageComposer/messageComposer.test.ts

@@ -760,7 +760,7 @@ describe('MessageComposer', () => {
           context: { composer: messageComposer },
         },
         options: {
-          code: 'api:poll:create:failed',
+          type: 'api:poll:create:failed',
           metadata: {
             reason: 'Failed to create poll',
           },