chore: fixed analysis errors (#516)

* fixed analysis errors

* tweaks

---------

Co-authored-by: Deven Joshi <[email protected]>

Author: Brazol

analysis_options.yaml

@@ -10,6 +10,8 @@ analyzer:
     # We explicitly enabled even conflicting rules and are fixing the conflict
     # in this file.
     included_file_warning: ignore
+    
+    todo: ignore
   exclude:
     # exclude all the generated files
     - packages/*/lib/**/*.*.dart
@@ -89,4 +91,10 @@ linter:
 
     # Not a common style and would add a lot of verbosity to function signature.
     # 'parameter_assignments' already enforces this to an extent.
-    prefer_final_parameters: false
+    prefer_final_parameters: false
+
+    # There are situations where we use default in enums on purpose
+    no_default_cases: false
+
+    # Would be a breaking change in some cases, no need to add those just for lintl cleanup
+    avoid_positional_boolean_parameters: false

development.md

@@ -45,7 +45,7 @@
 - [ ] Regular reconnection [Maciej,Kanat]
 - [ ] Support ICE restart reconnection [Maciej,Kanat]
 - [ ] Update WebRTC version to m114 (livekit version) [Kanat]
-- [ ] Fix analysis issues [Maciej]
+- [x] Fix analysis issues [Maciej]
 
 ### 0.4.0 milestone
 - [ ] Implement Chat overlay for Dogfooding app

dogfooding/lib/app/app.dart

@@ -92,8 +92,9 @@ class _StreamDogFoodingAppState extends State<StreamDogFoodingApp> {
         // This means that the app is now ready to use.
         if (snapshot.connectionState == ConnectionState.done) {
           if (snapshot.hasError) {
-            print(snapshot.error);
-            print(snapshot.stackTrace);
+            debugPrint(snapshot.error.toString());
+            debugPrint(snapshot.stackTrace.toString());
+
             return const Directionality(
               textDirection: TextDirection.ltr,
               child: Center(child: Text('Error loading app')),

dogfooding/lib/core/repos/user_auth_repository.dart

@@ -36,6 +36,7 @@ class UserAuthRepository {
 
 extension on UserResponseData {
   /// Converts [UserResponseData] to [UserInfo]
+  // ignore: unused_element
   UserInfo toUserInfo() {
     return UserInfo(
       id: id,

dogfooding/lib/screens/home_screen.dart

@@ -166,7 +166,6 @@ class _HomeScreenState extends State<HomeScreen> {
 
 class _JoinForm extends StatelessWidget {
   const _JoinForm({
-    super.key,
     required this.callIdController,
     required this.onJoinPressed,
   });

packages/stream_video/example/main.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: deprecated_member_use_from_same_package
+
 import 'dart:async';
 
 import 'package:meta/meta.dart';
@@ -265,11 +267,6 @@ class Call {
     _connectOptions = connectOptions;
   }
 
-  // This is only used in [_onStateChanged] to determine the difference between
-  // the previous and current state. It should not be used for any other
-  // purpose. It is not guaranteed to be the latest, Use [state] instead.
-  CallState? _prevState;
-
   void _observeState() {
     _subscriptions.add(
       _idState,
@@ -313,8 +310,6 @@ class Call {
         state.settings.audio.opusDtxEnabled;
     _sessionFactory.sdpEditor.opusRedEnabled =
         state.settings.audio.redundantCodingEnabled;
-
-    _prevState = state;
   }
 
   Future<void> _onCoordinatorEvent(CoordinatorCallEvent event) async {
@@ -530,7 +525,6 @@ class Call {
   }
 
   Future<Result<CallCredentials>> _joinIfNeeded() async {
-    final state = this.state.value;
     final creds = _credentials;
     if (creds != null) {
       _logger.w(() => '[joinIfNeeded] rejected (already joined): $creds');
@@ -605,8 +599,10 @@ class Call {
       _stateManager
           .lifecycleCallConnectingAction(CallConnecting(_reconnectAttempt));
       if (_status.value == _ConnectionStatus.disconnected) {
-        _logger.w(() =>
-            '[reconnect] attempt($_reconnectAttempt) rejected (disconnected)');
+        _logger.w(
+          () =>
+              '[reconnect] attempt($_reconnectAttempt) rejected (disconnected)',
+        );
         _logger.v(() => '[reconnect] <<<<<<<<<<<<<<< rejected');
         return;
       }
@@ -947,9 +943,6 @@ class Call {
 
   /// Allows you to create a new call with the given parameters
   /// and joins the call immediately.
-  ///
-  /// If a call with the same [cid] already exists,
-  /// it will join the existing call.
   Future<Result<CallJoinedData>> _joinCall({
     bool create = false,
   }) async {
@@ -1046,7 +1039,9 @@ class Call {
 
     if (result.isSuccess) {
       _stateManager.setCallBroadcasting(
-          isBroadcasting: true, hlsPlaylistUrl: result.getDataOrNull());
+        isBroadcasting: true,
+        hlsPlaylistUrl: result.getDataOrNull(),
+      );
     }
     return result;
   }

packages/stream_video/lib/src/call/call.dart

@@ -35,7 +35,7 @@ class CallConnectOptions with EquatableMixin {
     return 'CallConnectOptions{'
         'camera: $camera,'
         ' microphone: $microphone,'
-        ' screenShare: $screenShare,'
+        ' screenShare: $screenShare, '
         '}';
   }
 }

packages/stream_video/lib/src/call/call_connect_options.dart

@@ -1,10 +1,6 @@
 import 'package:meta/meta.dart';
 
-import '../../../open_api/video/coordinator/api.dart';
 import '../../../stream_video.dart';
-import '../../models/call_reaction.dart';
-import '../../models/queried_members.dart';
-import '../../utils/none.dart';
 import '../state/call_state_notifier.dart';
 
 typedef GetStateOrNull = CallState? Function();

packages/stream_video/lib/src/call/permissions/permissions_manager.dart

@@ -19,7 +19,6 @@ import '../../sfu/sfu_client_impl.dart';
 import '../../sfu/ws/sfu_ws.dart';
 import '../../shared_emitter.dart';
 import '../../utils/debounce_buffer.dart';
-import '../../utils/none.dart';
 import '../../webrtc/model/rtc_model_mapper_extensions.dart';
 import '../../webrtc/model/rtc_tracks_info.dart';
 import '../../webrtc/model/stats/rtc_printable_stats.dart';
@@ -289,13 +288,16 @@ class CallSession extends Disposable {
     await track.stop();
   }
 
-  Future<void> _onPublishQualityChanged(SfuChangePublishQualityEvent event) async {
+  Future<void> _onPublishQualityChanged(
+    SfuChangePublishQualityEvent event,
+  ) async {
     _logger.d(() => '[onPublishQualityChanged] event: $event');
 
     final enabledRids = event.videoSenders.firstOrNull?.layers
-        .where((e) => e.active)
-        .map((e) => e.name)
-        .toSet() ?? {};
+            .where((e) => e.active)
+            .map((e) => e.name)
+            .toSet() ??
+        {};
 
     _logger.v(() => '[onPublishQualityChanged] Enabled RIDs: $enabledRids');
 
@@ -332,7 +334,7 @@ class CallSession extends Disposable {
           sfu.TrackMuteState(
             trackType: track.trackType.toDTO(),
             muted: muted,
-          )
+          ),
         ],
       ),
     );

packages/stream_video/lib/src/call/session/call_session.dart

@@ -36,16 +36,20 @@ mixin StateCoordinatorMixin on StateNotifier<CallState> {
   ) {
     final status = state.status;
     if (status is! CallStatusOutgoing) {
-      _logger.w(() =>
-          '[coordinatorUpdateCallAccepted] rejected (status is not Outgoing)');
+      _logger.w(
+        () =>
+            '[coordinatorUpdateCallAccepted] rejected (status is not Outgoing)',
+      );
       return;
     }
     final participant = state.callParticipants.firstWhereOrNull((participant) {
       return participant.userId == event.acceptedByUserId;
     });
     if (participant == null) {
-      _logger.w(() =>
-          '[coordinatorUpdateCallAccepted] rejected (accepted by non-Member)');
+      _logger.w(
+        () =>
+            '[coordinatorUpdateCallAccepted] rejected (accepted by non-Member)',
+      );
       return;
     }
     state = state.copyWith(

packages/stream_video/lib/src/call/state/mixins/state_coordinator_mixin.dart

@@ -44,17 +44,16 @@ mixin StateParticipantMixin on StateNotifier<CallState> {
   void participantUpdateViewportVisibilities(
     UpdateViewportVisibilities action,
   ) {
-    for (final action in action.actions) {
-      participantUpdateViewportVisibility(action);
-    }
+    action.actions.forEach(participantUpdateViewportVisibility);
   }
 
   void participantUpdateSubscriptions(
     UpdateSubscriptions action,
   ) {
     final sessionId = state.sessionId;
     _logger.d(
-        () => '[participantUpdateSubscriptions] #$sessionId; action: $action');
+      () => '[participantUpdateSubscriptions] #$sessionId; action: $action',
+    );
     for (final action in action.actions) {
       if (action is UpdateSubscription) {
         participantUpdateSubscription(action);
@@ -67,8 +66,10 @@ mixin StateParticipantMixin on StateNotifier<CallState> {
   void participantUpdateSubscription(
     UpdateSubscription action,
   ) {
-    _logger.d(() =>
-        '[participantUpdateSubscription] #${state.sessionId}; action: $action');
+    _logger.d(
+      () =>
+          '[participantUpdateSubscription] #${state.sessionId}; action: $action',
+    );
     state = state.copyWith(
       callParticipants: state.callParticipants.map((participant) {
         final trackState = participant.publishedTracks[action.trackType];

packages/stream_video/lib/src/call/state/mixins/state_participant_mixin.dart

@@ -29,7 +29,7 @@ mixin StateRtcMixin on StateNotifier<CallState> {
                 muted: false,
                 subscribed: true,
                 received: true,
-              )
+              ),
             },
           );
         } else {

packages/stream_video/lib/src/call/state/mixins/state_rtc_mixin.dart

@@ -48,8 +48,9 @@ mixin StateSfuMixin on StateNotifier<CallState> {
     final participants = event.callState.participants.map((aParticipant) {
       final isLocal = aParticipant.userId == state.currentUserId;
       final existing = state.callParticipants.firstWhereOrNull(
-        (it) => it.userId == aParticipant.userId
-            && it.sessionId == aParticipant.sessionId,
+        (it) =>
+            it.userId == aParticipant.userId &&
+            it.sessionId == aParticipant.sessionId,
       );
       final existingName = existing?.name ?? '';
       final existingRole = existing?.role ?? '';
@@ -63,7 +64,7 @@ mixin StateSfuMixin on StateNotifier<CallState> {
         trackIdPrefix: aParticipant.trackLookupPrefix,
         publishedTracks: {
           for (final track in aParticipant.publishedTracks)
-            track: TrackState.base(isLocal: isLocal)
+            track: TrackState.base(isLocal: isLocal),
         },
         isLocal: isLocal,
         isOnline: !isLocal,

packages/stream_video/lib/src/call/state/mixins/state_sfu_mixin.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: one_member_abstracts
+
 import 'models/coordinator_events.dart';
 
 abstract class CoordinatorEventListener {

packages/stream_video/lib/src/coordinator/coordinator_socket_listener.dart

@@ -38,7 +38,6 @@ import '../models/coordinator_models.dart';
 import 'coordinator_ws_open_api.dart';
 import 'open_api_extensions.dart';
 
-const _idEvents = 1;
 const _waitForConnectionTimeout = 5000;
 
 /// An accessor that allows us to communicate with the API around video calls.
@@ -62,6 +61,7 @@ class CoordinatorClientOpenApi extends CoordinatorClient {
   final String _apiKey;
   final String _wsUrl;
   final TokenManager _tokenManager;
+  // ignore: unused_field
   final LatencyService _latencyService;
   final RetryPolicy _retryPolicy;
 
@@ -80,6 +80,7 @@ class CoordinatorClientOpenApi extends CoordinatorClient {
     ),
   );
   late final _defaultApi = open.DefaultApi(_apiClient);
+  // ignore: unused_field
   late final _serverSideApi = open.ServerSideApi(_apiClient);
   late final _locationService = LocationService();
 

packages/stream_video/lib/src/coordinator/open_api/coordinator_client_open_api.dart

@@ -1,6 +1,8 @@
 import 'dart:async';
 import 'dart:convert';
 
+import 'package:web_socket_channel/web_socket_channel.dart';
+
 import '../../../composed_version.dart';
 import '../../../open_api/video/coordinator/api.dart' as open;
 import '../../core/video_error.dart';
@@ -12,7 +14,6 @@ import '../../token/token_manager.dart';
 import '../../types/other.dart';
 import '../../utils/none.dart';
 import '../../utils/result.dart';
-import '../../ws/base_ws.dart';
 import '../../ws/health/health_monitor.dart';
 import '../coordinator_ws.dart';
 import '../models/coordinator_events.dart';
@@ -121,7 +122,7 @@ class CoordinatorWebSocketOpenApi extends CoordinatorWebSocket
         'custom': <String, dynamic>{
           'name': userInfo.name,
           if (image != null) ...{'image': image},
-          ...?userInfo.extraData,
+          ...userInfo.extraData,
         },
       },
     };
@@ -145,6 +146,7 @@ class CoordinatorWebSocketOpenApi extends CoordinatorWebSocket
     healthMonitor.onSocketError(error);
     connectionState = ConnectionState.failed;
 
+    // ignore: unused_local_variable
     StreamVideoWebSocketError wsError;
     if (error is WebSocketChannelException) {
       wsError = StreamVideoWebSocketError.fromWebSocketChannelError(error);
@@ -193,7 +195,7 @@ class CoordinatorWebSocketOpenApi extends CoordinatorWebSocket
     OpenApiError? dtoError;
     OpenApiEvent? dtoEvent;
     try {
-      final jsonDecoded = json.decode(message);
+      final jsonDecoded = json.decode(message) as Map<String, dynamic>;
       dtoError = OpenApiError.fromJson(jsonDecoded);
       dtoEvent = OpenApiEvent.fromJson(jsonDecoded);
     } catch (e, stk) {

packages/stream_video/lib/src/coordinator/open_api/coordinator_ws_open_api.dart

@@ -9,7 +9,7 @@ class OpenApiError {
     return OpenApiError.fromJson(json.decode(rawJson));
   }
 
-  static OpenApiError? fromJson(dynamic jsonObj) {
+  static OpenApiError? fromJson(Map<String, dynamic> jsonObj) {
     final errorObj = jsonObj['error'];
     if (errorObj == null) {
       return null;

packages/stream_video/lib/src/coordinator/open_api/error/open_api_error.dart

@@ -1,4 +1,4 @@
-class OpenApiErrorCode {
+mixin OpenApiErrorCode {
   static const tokenExpired = 40;
   static const tokenNotValid = 41;
   static const tokenDateIncorrect = 42;
@@ -9,6 +9,6 @@ class OpenApiErrorCode {
     tokenExpired,
     tokenNotValid,
     tokenDateIncorrect,
-    tokenSignatureIncorrect
+    tokenSignatureIncorrect,
   ];
 }