Skip to content

Commit c50068a

Browse files
authored
chore: fix the expo sample app pip mode (#1764)
### 💡 Overview This PR fixes pip issues in the expo sample app. when the app goes in pip mode only black screen was presented instead of the participant video. ### 📝 Implementation notes Adds missing pip configuration in the `app.json` and missing prop in the `CallContent` component 🎫 Ticket: https://linear.app/stream/issue/RN-193/picture-in-picture-fix-for-expo-sample-app
1 parent 01aac8a commit c50068a

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

sample-apps/react-native/expo-video-sample/app.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@
5050
"showWhenLockedAndroid": true
5151
},
5252
"enableNonRingingPushNotifications": true,
53-
"androidPictureInPicture": true
53+
"androidPictureInPicture": true,
54+
"iOSEnableMultitaskingCameraAccess": true
5455
}
5556
],
5657
"@config-plugins/react-native-callkeep",

sample-apps/react-native/expo-video-sample/components/MeetingUI.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export const MeetingUI = () => {
2424
call.leave();
2525
}
2626
};
27-
}, []);
27+
}, [call]);
2828

2929
if (callingState === CallingState.IDLE) {
3030
return <Lobby />;
@@ -33,7 +33,10 @@ export const MeetingUI = () => {
3333
}
3434
return (
3535
<SafeAreaView style={styles.container}>
36-
<CallContent CallControls={CallControlsComponent} />
36+
<CallContent
37+
CallControls={CallControlsComponent}
38+
iOSPiPIncludeLocalParticipantVideo={true}
39+
/>
3740
</SafeAreaView>
3841
);
3942
};

0 commit comments

Comments
 (0)