test: Remove the whole Directory.current hack

We now pass the working directory via a parameter. This has exposed a
number of issues all over, which have now all been fixed.

The hack was also occasionally failing and causing issues. I'm glad it
failed as it exposed all these other issues.

Author: vHanda

bin/commands/add.dart

@@ -1,7 +1,5 @@
 // ignore_for_file: avoid_print
 
-import 'dart:io';
-
 import 'package:args/command_runner.dart';
 
 import 'package:dart_git/git.dart';
@@ -13,10 +11,14 @@ class AddCommand extends Command<int> {
   @override
   final description = 'Add file contents to the index';
 
+  final String currentDir;
+
+  AddCommand(this.currentDir);
+
   @override
   int run() {
     // FIXME: if gitRootDir is not valid give an error!
-    var gitRootDir = GitRepository.findRootDir(Directory.current.path)!;
+    var gitRootDir = GitRepository.findRootDir(currentDir)!;
     var repo = GitRepository.load(gitRootDir);
 
     var pathSpec = argResults!.arguments[0];

bin/commands/branch.dart

@@ -1,7 +1,5 @@
 // ignore_for_file: avoid_print
 
-import 'dart:io';
-
 import 'package:args/command_runner.dart';
 
 import 'package:dart_git/git.dart';
@@ -15,15 +13,17 @@ class BranchCommand extends Command<int> {
   @override
   final description = 'List, create, or delete branches';
 
-  BranchCommand() {
+  final String currentDir;
+
+  BranchCommand(this.currentDir) {
     argParser.addOption('set-upstream-to');
     argParser.addFlag('all', abbr: 'a', defaultsTo: false);
     argParser.addFlag('delete', abbr: 'd', defaultsTo: false);
   }
 
   @override
   int run() {
-    var gitRootDir = GitRepository.findRootDir(Directory.current.path)!;
+    var gitRootDir = GitRepository.findRootDir(currentDir)!;
     var repo = GitRepository.load(gitRootDir);
 
     var showAll = argResults!['all'] as bool?;

bin/commands/cat_file.dart

@@ -1,7 +1,6 @@
 // ignore_for_file: avoid_print
 
 import 'dart:convert';
-import 'dart:io';
 
 import 'package:args/command_runner.dart';
 
@@ -16,9 +15,13 @@ class CatFileCommand extends Command<int> {
   final description =
       'Provide content or type and size information for repository objects';
 
+  final String currentDir;
+
+  CatFileCommand(this.currentDir);
+
   @override
   int run() {
-    var gitRootDir = GitRepository.findRootDir(Directory.current.path)!;
+    var gitRootDir = GitRepository.findRootDir(currentDir)!;
     var repo = GitRepository.load(gitRootDir);
 
     var objectSha1 = argResults!.arguments[1];

bin/commands/checkout.dart

@@ -1,7 +1,5 @@
 // ignore_for_file: avoid_print
 
-import 'dart:io';
-
 import 'package:args/command_runner.dart';
 
 import 'package:dart_git/git.dart';
@@ -15,13 +13,15 @@ class CheckoutCommand extends Command<int> {
   @override
   final description = 'Switch branches or restore working tree files';
 
-  CheckoutCommand() {
+  final String currentDir;
+
+  CheckoutCommand(this.currentDir) {
     argParser.addOption('branch', abbr: 'b', defaultsTo: '');
   }
 
   @override
   int run() {
-    var gitRootDir = GitRepository.findRootDir(Directory.current.path)!;
+    var gitRootDir = GitRepository.findRootDir(currentDir)!;
     var repo = GitRepository.load(gitRootDir);
 
     var branchName = argResults!['branch'] as String;

bin/commands/diff.dart

@@ -1,7 +1,5 @@
 // ignore_for_file: avoid_print
 
-import 'dart:io';
-
 import 'package:args/command_runner.dart';
 
 import 'package:dart_git/diff_commit.dart';
@@ -16,7 +14,9 @@ class DiffCommand extends Command<int> {
   final description =
       'Show changes between commits, commit and working tree, etc';
 
-  DiffCommand() {
+  final String currentDir;
+
+  DiffCommand(this.currentDir) {
     argParser.addFlag('raw');
   }
 
@@ -28,7 +28,7 @@ class DiffCommand extends Command<int> {
       return 1;
     }
 
-    var gitRootDir = GitRepository.findRootDir(Directory.current.path)!;
+    var gitRootDir = GitRepository.findRootDir(currentDir)!;
     var repo = GitRepository.load(gitRootDir);
 
     var fromStr = argResults!.arguments[0];

bin/commands/diff_tree.dart

@@ -1,7 +1,5 @@
 // ignore_for_file: avoid_print
 
-import 'dart:io';
-
 import 'package:args/command_runner.dart';
 
 import 'package:dart_git/diff_tree.dart';
@@ -17,9 +15,13 @@ class DiffTreeCommand extends Command<int> {
   final description =
       'Compares the content and mode of blobs found via two tree objects';
 
+  final String currentDir;
+
+  DiffTreeCommand(this.currentDir);
+
   @override
   int run() {
-    var gitRootDir = GitRepository.findRootDir(Directory.current.path)!;
+    var gitRootDir = GitRepository.findRootDir(currentDir)!;
     var repo = GitRepository.load(gitRootDir);
 
     var hash = argResults!.arguments[0];

bin/commands/dump_index.dart

@@ -1,7 +1,5 @@
 // ignore_for_file: avoid_print
 
-import 'dart:io';
-
 import 'package:args/command_runner.dart';
 
 import 'package:dart_git/git.dart';
@@ -13,9 +11,13 @@ class DumpIndexCommand extends Command<int> {
   @override
   final description = 'Prints the contents of the .git/index';
 
+  final String currentDir;
+
+  DumpIndexCommand(this.currentDir);
+
   @override
   int run() {
-    var gitRootDir = GitRepository.findRootDir(Directory.current.path)!;
+    var gitRootDir = GitRepository.findRootDir(currentDir)!;
     var repo = GitRepository.load(gitRootDir);
 
     var index = repo.indexStorage.readIndex();

bin/commands/hash_object.dart

@@ -3,6 +3,7 @@
 import 'dart:io';
 
 import 'package:args/command_runner.dart';
+import 'package:path/path.dart' as p;
 
 import 'package:dart_git/git.dart';
 import 'package:dart_git/plumbing/git_hash.dart';
@@ -16,7 +17,9 @@ class HashObjectCommand extends Command<int> {
   final description =
       'Compute object ID and optionally creates a blob from a file';
 
-  HashObjectCommand() {
+  final String currentDir;
+
+  HashObjectCommand(this.currentDir) {
     argParser.addOption(
       'type',
       abbr: 't',
@@ -39,10 +42,13 @@ class HashObjectCommand extends Command<int> {
       return 1;
     }
     var filePath = argResults!.rest[0];
+    if (!File(filePath).existsSync()) {
+      filePath = p.join(currentDir, filePath);
+    }
     var rawData = File(filePath).readAsBytesSync();
     var hash = GitHash.compute(rawData);
 
-    var gitRootDir = GitRepository.findRootDir(Directory.current.path)!;
+    var gitRootDir = GitRepository.findRootDir(currentDir)!;
     var repo = GitRepository.load(gitRootDir);
 
     var fmt = argResults!['type'] as String;

bin/commands/init.dart

@@ -13,7 +13,9 @@ class InitCommand extends Command<int> {
   final description =
       'Create an empty Git repository or reinitialize an existing one';
 
-  InitCommand() {
+  final String currentDir;
+
+  InitCommand(this.currentDir) {
     argParser.addFlag('quiet', abbr: 'q', defaultsTo: false);
     argParser.addOption('initial-branch', abbr: 'b', defaultsTo: 'main');
   }
@@ -25,7 +27,7 @@ class InitCommand extends Command<int> {
       return 1;
     }
 
-    var path = argResults!.rest.first;
+    var path = p.join(currentDir, argResults!.rest.first);
     var defaultBranch = argResults!['initial-branch'] as String;
     GitRepository.init(path, defaultBranch: defaultBranch);
 

bin/commands/log.dart

@@ -1,7 +1,6 @@
 // ignore_for_file: avoid_print
 
 import 'dart:convert';
-import 'dart:io';
 
 import 'package:args/command_runner.dart';
 
@@ -17,9 +16,13 @@ class LogCommand extends Command<int> {
   @override
   final description = 'Show commit logs';
 
+  final String currentDir;
+
+  LogCommand(this.currentDir);
+
   @override
   int run() {
-    var gitRootDir = GitRepository.findRootDir(Directory.current.path)!;
+    var gitRootDir = GitRepository.findRootDir(currentDir)!;
     var repo = GitRepository.load(gitRootDir);
 
     GitHash? sha;