Skip to content

Commit f0d4dcc

Browse files
committed
Reverted back AuthCredential logic
1 parent 27c990f commit f0d4dcc

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

firebase-auth/src/androidMain/kotlin/dev/gitlive/firebase/auth/credentials.kt

+3-3
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ actual class PhoneAuthProvider(val createOptionsBuilder: () -> PhoneAuthOptions.
8585

8686
actual fun credential(verificationId: String, smsCode: String): PhoneAuthCredential = PhoneAuthCredential(com.google.firebase.auth.PhoneAuthProvider.getCredential(verificationId, smsCode))
8787

88-
actual suspend fun verifyPhoneNumber(phoneNumber: String, verificationProvider: PhoneVerificationProvider): PhoneAuthCredential = coroutineScope {
89-
val response = CompletableDeferred<Result<PhoneAuthCredential>>()
88+
actual suspend fun verifyPhoneNumber(phoneNumber: String, verificationProvider: PhoneVerificationProvider): AuthCredential = coroutineScope {
89+
val response = CompletableDeferred<Result<AuthCredential>>()
9090
val callback = object :
9191
PhoneAuthProvider.OnVerificationStateChangedCallbacks() {
9292

@@ -115,7 +115,7 @@ actual class PhoneAuthProvider(val createOptionsBuilder: () -> PhoneAuthOptions.
115115
}
116116

117117
override fun onVerificationCompleted(credential: com.google.firebase.auth.PhoneAuthCredential) {
118-
response.complete(Result.success(PhoneAuthCredential(credential)))
118+
response.complete(Result.success(AuthCredential(credential)))
119119
}
120120

121121
override fun onVerificationFailed(error: FirebaseException) {

firebase-auth/src/commonMain/kotlin/dev/gitlive/firebase/auth/credentials.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ expect class OAuthProvider constructor(
4343

4444
expect class PhoneAuthProvider constructor(auth: FirebaseAuth = Firebase.auth) {
4545
fun credential(verificationId: String, smsCode: String): PhoneAuthCredential
46-
suspend fun verifyPhoneNumber(phoneNumber: String, verificationProvider: PhoneVerificationProvider): PhoneAuthCredential
46+
suspend fun verifyPhoneNumber(phoneNumber: String, verificationProvider: PhoneVerificationProvider): AuthCredential
4747
}
4848

4949
expect interface PhoneVerificationProvider

firebase-auth/src/iosMain/kotlin/dev/gitlive/firebase/auth/credentials.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ actual class PhoneAuthProvider(val ios: FIRPhoneAuthProvider) {
7676

7777
actual fun credential(verificationId: String, smsCode: String): PhoneAuthCredential = PhoneAuthCredential(ios.credentialWithVerificationID(verificationId, smsCode))
7878

79-
actual suspend fun verifyPhoneNumber(phoneNumber: String, verificationProvider: PhoneVerificationProvider): PhoneAuthCredential {
79+
actual suspend fun verifyPhoneNumber(phoneNumber: String, verificationProvider: PhoneVerificationProvider): AuthCredential {
8080
val verificationId: String = ios.awaitResult { ios.verifyPhoneNumber(phoneNumber, verificationProvider.delegate, it) }
8181
val verificationCode = verificationProvider.getVerificationCode()
8282
return credential(verificationId, verificationCode)

firebase-auth/src/jsMain/kotlin/dev/gitlive/firebase/auth/credentials.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ actual class PhoneAuthProvider(val js: PhoneAuthProvider) {
8383
actual constructor(auth: FirebaseAuth) : this(PhoneAuthProvider(auth.js))
8484

8585
actual fun credential(verificationId: String, smsCode: String): PhoneAuthCredential = PhoneAuthCredential(PhoneAuthProvider.credential(verificationId, smsCode))
86-
actual suspend fun verifyPhoneNumber(phoneNumber: String, verificationProvider: PhoneVerificationProvider): PhoneAuthCredential = rethrow {
86+
actual suspend fun verifyPhoneNumber(phoneNumber: String, verificationProvider: PhoneVerificationProvider): AuthCredential = rethrow {
8787
val verificationId = js.verifyPhoneNumber(phoneNumber, verificationProvider.verifier).await()
8888
val verificationCode = verificationProvider.getVerificationCode(verificationId)
8989
credential(verificationId, verificationCode)

firebase-auth/src/jvmMain/kotlin/dev/gitlive/firebase/auth/credentials.kt

+3-3
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ actual class PhoneAuthProvider(val android: com.google.firebase.auth.PhoneAuthPr
8484

8585
actual fun credential(verificationId: String, smsCode: String): PhoneAuthCredential = PhoneAuthCredential(com.google.firebase.auth.PhoneAuthProvider.getCredential(verificationId, smsCode))
8686

87-
actual suspend fun verifyPhoneNumber(phoneNumber: String, verificationProvider: PhoneVerificationProvider): PhoneAuthCredential = coroutineScope {
88-
val response = CompletableDeferred<Result<PhoneAuthCredential>>()
87+
actual suspend fun verifyPhoneNumber(phoneNumber: String, verificationProvider: PhoneVerificationProvider): AuthCredential = coroutineScope {
88+
val response = CompletableDeferred<Result<AuthCredential>>()
8989
val callback = object :
9090
PhoneAuthProvider.OnVerificationStateChangedCallbacks() {
9191

@@ -107,7 +107,7 @@ actual class PhoneAuthProvider(val android: com.google.firebase.auth.PhoneAuthPr
107107
}
108108

109109
override fun onVerificationCompleted(credential: com.google.firebase.auth.PhoneAuthCredential) {
110-
response.complete(Result.success(PhoneAuthCredential(credential)))
110+
response.complete(Result.success(AuthCredential(credential)))
111111
}
112112

113113
override fun onVerificationFailed(error: FirebaseException) {

0 commit comments

Comments
 (0)