add Qodana static code analysis

Author: arturcic

.editorconfig

@@ -68,9 +68,9 @@ dotnet_diagnostic.CA1016.severity = none
 #### C# Coding Conventions ####
 
 # Prefer "var" everywhere
-csharp_style_var_for_built_in_types = true:silent
-csharp_style_var_when_type_is_apparent = true:silent
-csharp_style_var_elsewhere = true:silent
+csharp_style_var_for_built_in_types = true:suggestion
+csharp_style_var_when_type_is_apparent = true:suggestion
+csharp_style_var_elsewhere = true:suggestion
 
 # Prefer method-like constructs to have a block body, except for lambdas
 csharp_style_expression_bodied_methods = true:warning
@@ -152,9 +152,10 @@ csharp_space_between_method_call_parameter_list_parentheses = false
 csharp_space_between_method_declaration_empty_parameter_list_parentheses = false
 csharp_space_between_method_declaration_name_and_open_parenthesis = false
 csharp_space_between_method_declaration_parameter_list_parentheses = false
-csharp_space_between_parentheses = false
 csharp_space_between_square_brackets = false
 
+csharp_use_roslyn_logic_for_evident_types = true
+
 # Alignment
 align_multiline_parameter = true
 
@@ -194,4 +195,4 @@ dotnet_diagnostic.RCS1037.severity = error
 # RCS1036: Remove redundant empty line.
 dotnet_diagnostic.RCS1036.severity = error
 
-[resharper_]xml_space_before_self_closing = true
+xml_space_before_self_closing = true

.github/workflows/qodana_code_quality.yml

@@ -0,0 +1,24 @@
+name: Qodana
+on:
+  workflow_dispatch:
+  pull_request:
+  push:
+    branches:
+      - main
+
+jobs:
+  qodana:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+      pull-requests: write
+      checks: write
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+          fetch-depth: 0
+      - name: 'Qodana Scan'
+        uses: jetbrains/[email protected]
+        env:
+          QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }}

.gitignore

@@ -61,7 +61,6 @@ TestResults
 ClientBin
 stylecop.*
 ~$*
-*~
 *.dbmdl
 site/
 Generated_Code #added for RIA/Silverlight projects

build/CI.slnx

@@ -44,6 +44,7 @@
     <File Path="../.github/workflows/release.yml" />
     <File Path="../.github/workflows/stale.yml" />
     <File Path="../.github/workflows/winget.yml" />
+    <File Path="../.github/workflows/qodana_code_quality.yml" />
   </Folder>
   <Folder Name="/workflows/_/">
     <File Path="../.github/workflows/_artifacts_linux.yml" />

qodana.yaml

@@ -0,0 +1,87 @@
+#-------------------------------------------------------------------------------#
+#               Qodana analysis is configured by qodana.yaml file               #
+#             https://www.jetbrains.com/help/qodana/qodana-yaml.html            #
+#-------------------------------------------------------------------------------#
+version: "1.0"
+#Specify IDE code to run analysis without container (Applied in CI/CD pipeline)
+ide: QDNET
+#Specify inspection profile for code analysis
+profile:
+  name: qodana.starter
+include:
+  - name: ConvertIfStatementToReturnStatement
+  - name: ConvertIfStatementToConditionalTernaryExpression
+  - name: AutoPropertyCanBeMadeGetOnly.Global
+  - name: CanReplaceCastWithLambdaReturnType
+  - name: ChangeFieldTypeToSystemThreadingLock
+  - name: ConvertIfStatementToSwitchStatement
+  - name: ConvertToConstant.Local
+  - name: DuplicatedSequentialIfBodies
+  - name: InlineTemporaryVariable
+  - name: InvertIf
+  - name: UseVerbatimString
+  - name: LoopCanBeConvertedToQuery
+  - name: MemberCanBePrivate.Global
+  - name: MemberCanBeProtected.Global
+  - name: MergeIntoPattern
+  - name: UnusedMethodReturnValue.Global
+  - name: EditorConfigNoMatchingFiles
+  - name: ForeachCanBePartlyConvertedToQueryUsingAnotherGetEnumerator
+  - name: PreferConcreteValueOverDefault
+  - name: PropertyCanBeMadeInitOnly.Global
+  - name: MoveLocalFunctionAfterJumpStatement
+  - name: RedundantExplicitParamsArrayCreation
+  - name: RedundantOverload.Global
+  - name: RedundantStringInterpolation
+  - name: RedundantVerbatimStringPrefix
+  - name: ReplaceSubstringWithRangeIndexer
+  - name: RCS1001
+  - name: RCS1003
+  - name: RCS1123
+  - name: SYSLIB1045
+  - name: CA1826
+  - name: RCS1256
+  - name: RCS1118
+  - name: RCS1077
+  - name: RCS1205
+  - name: RCS1214
+  - name: RCS1249
+  - name: RCS1192
+  - name: SYSLIB1054
+  - name: CA1512
+  - name: CA1866
+  - name: CA1859
+  - name: RCS1246
+  - name: CA1829
+  - name: RCS1266
+  - name: RCS1267
+  - name: RCS1227
+  - name: SwitchExpressionHandlesSomeKnownEnumValuesWithExceptionInDefault
+  - name: SwitchStatementHandlesSomeKnownEnumValuesWithDefault
+  - name: RedundantAlwaysMatchSubpattern
+  - name: UnusedType.Global
+  - name: UnusedMemberInSuper.Global
+  - name: UnusedMember.Local
+  - name: EditorConfigKeyCorrectness
+  - name: UseCollectionCountProperty
+  - name: UseDiscardAssignment
+  - name: ArrangeNamespaceBody
+  - name: SuggestDiscardDeclarationVarStyle
+  - name: ArrangeTrailingCommaInMultilineLists
+  - name: ArrangeObjectCreationWhenTypeNotEvident
+  - name: UseRawString
+  - name: VirtualMemberNeverOverridden.Global
+
+#Enable inspections
+#include:
+#  - name: <SomeEnabledInspectionId>
+#Disable inspections
+#exclude:
+#  - name: <SomeDisabledInspectionId>
+#    paths:
+#      - <path/where/not/run/inspection>
+#Execute shell command before Qodana execution (Applied in CI/CD pipeline)
+#bootstrap: sh ./prepare-qodana.sh
+#Install IDE plugins before Qodana execution (Applied in CI/CD pipeline)
+#plugins:
+#  - id: <plugin.id> #(plugin id can be found at https://plugins.jetbrains.com)

src/GitVersion.App.Tests/HelpWriterTests.cs

@@ -35,7 +35,7 @@ public void AllArgsAreInHelp()
             { nameof(Arguments.ShowVariable), "/showvariable" },
             { nameof(Arguments.Format), "/format" }
         };
-        string helpText = string.Empty;
+        var helpText = string.Empty;
 
         this.helpWriter.WriteTo(s => helpText = s);
 

src/GitVersion.App.Tests/VersionWriterTests.cs

@@ -22,7 +22,7 @@ public void WriteVersionShouldWriteFileVersionWithNoPrereleaseTag()
     {
         var asm = GenerateAssembly(new Version(1, 0, 0), "");
 
-        string? version = string.Empty;
+        var version = string.Empty;
         this.versionWriter.WriteTo(asm, v => version = v);
         Assert.Multiple(() =>
         {
@@ -36,7 +36,7 @@ public void WriteVersionShouldWriteFileVersionWithPrereleaseTag()
     {
         var asm = GenerateAssembly(new Version(1, 0, 0), "-beta4");
 
-        string? version = string.Empty;
+        var version = string.Empty;
         this.versionWriter.WriteTo(asm, v => version = v);
         Assert.Multiple(() =>
         {

src/GitVersion.App/OverrideConfigurationOptionParser.cs

@@ -41,7 +41,7 @@ internal class OverrideConfigurationOptionParser
     /// <remarks>Only simple types are supported</remarks>
     private static bool IsSupportedPropertyType(Type propertyType)
     {
-        Type unwrappedType = Nullable.GetUnderlyingType(propertyType) ?? propertyType;
+        var unwrappedType = Nullable.GetUnderlyingType(propertyType) ?? propertyType;
 
         return unwrappedType == typeof(string)
                || unwrappedType.IsEnum

src/GitVersion.App/QuotedStringHelpers.cs

@@ -26,13 +26,13 @@ public static string[] SplitUnquoted(string? input, char splitChar)
             return [];
 
         var split = new List<string>();
-        bool isPreviousCharBackslash = false;
-        bool isInsideQuotes = false;
+        var isPreviousCharBackslash = false;
+        var isInsideQuotes = false;
 
-        int startIndex = 0;
-        for (int i = 0; i < input.Length; i++)
+        var startIndex = 0;
+        for (var i = 0; i < input.Length; i++)
         {
-            char current = input[i];
+            var current = input[i];
             switch (current)
             {
                 case '"':

src/GitVersion.Configuration/ConfigurationFileLocator.cs

@@ -40,7 +40,7 @@ public void Verify(string? workingDirectory, string? projectRootDirectory)
 
     public string? GetConfigurationFile(string? directoryPath)
     {
-        string? customConfigurationFile = GetCustomConfigurationFilePathIfEligable(directoryPath);
+        var customConfigurationFile = GetCustomConfigurationFilePathIfEligable(directoryPath);
         if (!string.IsNullOrWhiteSpace(customConfigurationFile))
         {
             this.log.Info($"Found configuration file at '{customConfigurationFile}'");
@@ -52,7 +52,7 @@ public void Verify(string? workingDirectory, string? projectRootDirectory)
             return null;
         }
 
-        string[] files = fileSystem.Directory.GetFiles(directoryPath);
+        var files = fileSystem.Directory.GetFiles(directoryPath);
         foreach (var fileName in this.SupportedConfigFileNames)
         {
             this.log.Debug($"Trying to find configuration file {fileName} at '{directoryPath}'");
@@ -71,7 +71,7 @@ public void Verify(string? workingDirectory, string? projectRootDirectory)
     {
         if (!string.IsNullOrWhiteSpace(this.ConfigurationFile))
         {
-            string configurationFilePath = this.ConfigurationFile;
+            var configurationFilePath = this.ConfigurationFile;
             if (!string.IsNullOrWhiteSpace(directoryPath))
             {
                 configurationFilePath = FileSystemHelper.Path.Combine(directoryPath, this.ConfigurationFile);