Skip to content

Commit 26cf998

Browse files
ByronEliahKagan
authored andcommitted
fix: add support for 'any' unit, when parsing <count> <unit> ago.
Similar to Git, any unit is allowed and will default to seconds, like `60 flurps ago` will mean a minute in the past.
1 parent 856b385 commit 26cf998

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

gix-date/src/parse.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ mod relative {
156156
"month" => Span::new().try_months(units),
157157
"year" => Span::new().try_years(units),
158158
// Ignore values you don't know, assume seconds then (so does git)
159-
_ => return None,
159+
_anything => Span::new().try_seconds(units),
160160
};
161161
Some(result.map_err(|_| Error::RelativeTimeConversion))
162162
}

gix-date/tests/time/parse.rs

+1
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,7 @@ mod relative {
184184
// For comparison, a few are the same as in: https://github.com/git/git/blob/master/t/t0006-date.sh
185185
let cases = [
186186
("5 seconds ago", 5.seconds()),
187+
("12345 florx ago", 12_345.seconds()), // Anything parses as seconds
187188
("5 minutes ago", 5.minutes()),
188189
("5 hours ago", 5.hours()),
189190
("5 days ago", 5.days()),

0 commit comments

Comments
 (0)