[DRAFT] Allow switching hybrid mode on desktop for testing #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
force-pushed
the
simulated-hybrid
branch
2 times, most recently
from
a0c46d2 to
bcb73e4
Compare
dsnopek
force-pushed
the
simulated-hybrid
branch
2 times, most recently
from
dea17f8 to
d845e3c
Compare
dsnopek
force-pushed
the
simulated-hybrid
branch
from
d845e3c to
a144c77
Compare
m4gr3d
reviewed
Aug 7, 2025
m4gr3d
reviewed
Aug 7, 2025
| mode_args.push_back(Marshalls::get_singleton()->utf8_to_base64(p_data)); | ||
| } | ||
|
|
||
| // This path works when running from the editor. |
Collaborator
There was a problem hiding this comment.
Should it be gated with #ifdef TOOLS_ENABLED?
Collaborator
Author
There was a problem hiding this comment.
We could, but we're not making distinct editor and debug builds for this extension - we're just making debug and release builds, so it wouldn't make any difference. I don't think we're currently using TOOLS_ENABLED anywhere, even in our editor plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows switching hybrid mode between immersive and panel on desktop for testing. When paired with the Meta XR Simulator or Monado's QWERTY driver, this can allow developers to test out mode switching without putting on a headset.
When running from the editor, it should work with the embedded game view (only tested on Linux with Monado so far), and still have a working debugger and remote scene tree after the mode switch.
Marked as a DRAFT for now, because it depends:
Clean-up editor plugins and class registration #308Since this depends on
extension_api.jsonchanges that won't be available until Godot 4.6 at the earliest, we won't be able to merge this until this plugin is targeting Godot 4.6+