core(apple-touch-icon): remove audit (#14243)

Author: alexnj

build/build-sample-reports.js

@@ -191,14 +191,6 @@ async function generateErrorLHR() {
   offscreenImagesAudit.errorMessage = undefined;
   offscreenImagesAudit.scoreDisplayMode = 'binary';
   offscreenImagesAudit.score = 1;
-  // pwa-apple-touch-icon - set as passing but with a warning
-  const appleTouchIconAudit = errorLhr.audits['apple-touch-icon'];
-  appleTouchIconAudit.warnings = [
-    '`apple-touch-icon-precomposed` is out of date; `apple-touch-icon` is preferred.',
-  ];
-  appleTouchIconAudit.errorMessage = undefined;
-  appleTouchIconAudit.scoreDisplayMode = 'binary';
-  appleTouchIconAudit.score = 1;
 
   fs.rmSync(TMP, {recursive: true, force: true});
   return errorLhr;

lighthouse-cli/test/smokehouse/test-definitions/pwa-airhorner.js

@@ -44,9 +44,6 @@ const expectations = {
       'content-width': {
         score: 1,
       },
-      'apple-touch-icon': {
-        score: 1,
-      },
 
       // "manual" audits. Just verify in the results.
       'pwa-cross-browser': {

lighthouse-cli/test/smokehouse/test-definitions/pwa-caltrain.js

@@ -43,9 +43,6 @@ const expectations = {
       'content-width': {
         score: 1,
       },
-      'apple-touch-icon': {
-        score: 1,
-      },
 
       // "manual" audits. Just verify in the results.
       'pwa-cross-browser': {

lighthouse-cli/test/smokehouse/test-definitions/pwa-chromestatus.js

@@ -40,9 +40,6 @@ const expectations = {
       'content-width': {
         score: 1,
       },
-      'apple-touch-icon': {
-        score: 1,
-      },
 
       // "manual" audits. Just verify in the results.
       'pwa-cross-browser': {

lighthouse-cli/test/smokehouse/test-definitions/pwa-rocks.js

@@ -48,9 +48,6 @@ const expectations = {
       'content-width': {
         score: 1,
       },
-      'apple-touch-icon': {
-        score: 1,
-      },
 
       // "manual" audits. Just verify in the results.
       'pwa-cross-browser': {

lighthouse-cli/test/smokehouse/test-definitions/pwa-svgomg.js

@@ -52,9 +52,6 @@ const expectations = {
       'content-width': {
         score: 1,
       },
-      'apple-touch-icon': {
-        score: 1,
-      },
 
       // "manual" audits. Just verify in the results.
       'pwa-cross-browser': {

lighthouse-core/audits/apple-touch-icon.js

@@ -298,7 +298,6 @@ const defaultConfig = {
     'critical-request-chains',
     'redirects',
     'installable-manifest',
-    'apple-touch-icon',
     'splash-screen',
     'themed-omnibox',
     'maskable-icon',
@@ -723,7 +722,6 @@ const defaultConfig = {
         {id: 'themed-omnibox', weight: 1, group: 'pwa-optimized'},
         {id: 'content-width', weight: 1, group: 'pwa-optimized'},
         {id: 'viewport', weight: 2, group: 'pwa-optimized'},
-        {id: 'apple-touch-icon', weight: 1, group: 'pwa-optimized'},
         {id: 'maskable-icon', weight: 1, group: 'pwa-optimized'},
         // Manual audits
         {id: 'pwa-cross-browser', weight: 0},

lighthouse-core/config/default-config.js

@@ -1257,7 +1257,7 @@ describe('Config', () => {
         extends: 'lighthouse:default',
         settings: {
           onlyCategories: ['pwa'],
-          onlyAudits: ['apple-touch-icon'],
+          onlyAudits: ['viewport'],
         },
       };
       const config = await Config.fromJson(extended);