fix: explicitly configure disabled IAP (#4139)

Author: singhal0306

modules/net-lb-app-ext-regional/backend-service.tf

@@ -194,14 +194,11 @@ resource "google_compute_region_backend_service" "default" {
     }
   }
 
-  dynamic "iap" {
-    for_each = each.value.iap_config == null ? [] : [each.value.iap_config]
-    content {
-      enabled                     = true
-      oauth2_client_id            = try(iap.value.oauth2_client_id, null)
-      oauth2_client_secret        = try(iap.value.oauth2_client_secret, null)
-      oauth2_client_secret_sha256 = try(iap.value.oauth2_client_secret_sha256, null)
-    }
+  iap {
+    enabled                     = each.value.iap_config != null
+    oauth2_client_id            = try(each.value.iap_config.oauth2_client_id, null)
+    oauth2_client_secret        = try(each.value.iap_config.oauth2_client_secret, null)
+    oauth2_client_secret_sha256 = try(each.value.iap_config.oauth2_client_secret_sha256, null)
   }
 
   dynamic "log_config" {

modules/net-lb-app-ext/backend-service.tf

@@ -209,14 +209,11 @@ resource "google_compute_backend_service" "default" {
     }
   }
 
-  dynamic "iap" {
-    for_each = each.value.iap_config == null ? [] : [each.value.iap_config]
-    content {
-      enabled                     = true
-      oauth2_client_id            = try(iap.value.oauth2_client_id, null)
-      oauth2_client_secret        = try(iap.value.oauth2_client_secret, null)
-      oauth2_client_secret_sha256 = try(iap.value.oauth2_client_secret_sha256, null)
-    }
+  iap {
+    enabled                     = each.value.iap_config != null
+    oauth2_client_id            = try(each.value.iap_config.oauth2_client_id, null)
+    oauth2_client_secret        = try(each.value.iap_config.oauth2_client_secret, null)
+    oauth2_client_secret_sha256 = try(each.value.iap_config.oauth2_client_secret_sha256, null)
   }
 
   dynamic "log_config" {

modules/net-lb-app-int-cross-region/backend-service.tf

@@ -139,14 +139,11 @@ resource "google_compute_backend_service" "default" {
     }
   }
 
-  dynamic "iap" {
-    for_each = each.value.iap_config == null ? [] : [each.value.iap_config]
-    content {
-      enabled                     = true
-      oauth2_client_id            = try(iap.value.oauth2_client_id, null)
-      oauth2_client_secret        = try(iap.value.oauth2_client_secret, null)
-      oauth2_client_secret_sha256 = try(iap.value.oauth2_client_secret_sha256, null)
-    }
+  iap {
+    enabled                     = each.value.iap_config != null
+    oauth2_client_id            = try(each.value.iap_config.oauth2_client_id, null)
+    oauth2_client_secret        = try(each.value.iap_config.oauth2_client_secret, null)
+    oauth2_client_secret_sha256 = try(each.value.iap_config.oauth2_client_secret_sha256, null)
   }
 
   dynamic "log_config" {

modules/net-lb-app-int/backend-service.tf

@@ -152,14 +152,11 @@ resource "google_compute_region_backend_service" "default" {
     }
   }
 
-  dynamic "iap" {
-    for_each = each.value.iap_config == null ? [] : [each.value.iap_config]
-    content {
-      enabled                     = true
-      oauth2_client_id            = try(iap.value.oauth2_client_id, null)
-      oauth2_client_secret        = try(iap.value.oauth2_client_secret, null)
-      oauth2_client_secret_sha256 = try(iap.value.oauth2_client_secret_sha256, null)
-    }
+  iap {
+    enabled                     = each.value.iap_config != null
+    oauth2_client_id            = try(each.value.iap_config.oauth2_client_id, null)
+    oauth2_client_secret        = try(each.value.iap_config.oauth2_client_secret, null)
+    oauth2_client_secret_sha256 = try(each.value.iap_config.oauth2_client_secret_sha256, null)
   }
 
   dynamic "log_config" {