Skip to content
This repository has been archived by the owner on Jan 2, 2023. It is now read-only.

IntialNode Count MaxCount MinCount Validation #22

Open
chrislovecnm opened this issue Sep 8, 2019 · 2 comments
Open

IntialNode Count MaxCount MinCount Validation #22

chrislovecnm opened this issue Sep 8, 2019 · 2 comments

Comments

@chrislovecnm
Copy link
Contributor

The validation for initialNodeCount: 2 working weird.

This works

  nodePools:
    - metadata:
        name: my-node-pool
      spec:
        minCount: 2
        maxCount: 2
        initialNodeCount: 2

This does not work:

  nodePools:
    - metadata:
        name: my-node-pool
      spec:
        minCount: 2
        initialNodeCount: 2

This does not work:

  nodePools:
    - metadata:
        name: my-node-pool
      spec:
        initialNodeCount: 2
@chrislovecnm
Copy link
Contributor Author

We need to decide exactly how it should work. If initialNodeCount is set, but min and max are not set, what do we set them to?? How does this impact autoscaling??

@bgeesaman @robinpercy @wripley

@bgeesaman
Copy link
Contributor

My thoughts:

If min and max are not set, no autoscaling is to be enabled OR, set min and max to same as initialnodecount and warn?
If only min is set, validation error for not providing max.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants