Skip to content

Commit 50122b4

Browse files
appengine: fix permadiff and cleanup
1 parent d0bd7c8 commit 50122b4

3 files changed

Lines changed: 3 additions & 16 deletions

File tree

mmv1/products/appengine/StandardAppVersion.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -374,6 +374,7 @@ properties:
374374
- manual_scaling
375375
# This flattener is entirely handwritten and must be updated with **any** new field or subfield
376376
custom_flatten: templates/terraform/custom_flatten/appengine_standardappversion_automatic_scaling_handlenil.go.tmpl
377+
default_from_api: true
377378
properties:
378379
- name: maxConcurrentRequests
379380
type: Integer

mmv1/templates/terraform/samples/services/appengine/app_engine_standard_app_version.tf.tmpl

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -72,18 +72,8 @@ resource "google_app_engine_standard_app_version" "myapp_v2" {
7272
port = "8080"
7373
}
7474

75-
automatic_scaling {
76-
max_concurrent_requests = 10
77-
min_idle_instances = 1
78-
max_idle_instances = 3
79-
min_pending_latency = "1s"
80-
max_pending_latency = "5s"
81-
standard_scheduler_settings {
82-
target_cpu_utilization = 0.5
83-
target_throughput_utilization = 0.75
84-
min_instances = 2
85-
max_instances = 10
86-
}
75+
basic_scaling {
76+
max_instances = 5
8777
}
8878

8979
noop_on_destroy = true

mmv1/templates/terraform/samples/services/iap/iap_app_engine_service.tf.tmpl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,6 @@ resource "google_app_engine_standard_app_version" "version" {
4040
runtime = "nodejs22"
4141
noop_on_destroy = true
4242

43-
// TODO: Removed basic scaling once automatic_scaling refresh behavior is fixed.
44-
basic_scaling {
45-
max_instances = 5
46-
}
4743
entrypoint {
4844
shell = "node ./app.js"
4945
}

0 commit comments

Comments
 (0)