Skip to content

airflow_db_cleanup.py Version check logic doesn't work for Airflow 2.10.x and above. #13288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
miguelars23 opened this issue Apr 3, 2025 · 1 comment · Fixed by #13295
Closed

airflow_db_cleanup.py Version check logic doesn't work for Airflow 2.10.x and above. #13288

miguelars23 opened this issue Apr 3, 2025 · 1 comment · Fixed by #13295
Assignees
@iennae @eapl-gemugami
Labels
samples Issues that are directly related to samples.

Comments

@miguelars23
Copy link

Splitting AIRFLOW_VERSION as an arrange of Strings and comparing it like this:

if AIRFLOW_VERSION < ["2", "2", "0"]

won't work for versions 2.10.x and above as Python evaluates "10" < "2" to true. Converting the strings to integers could be the easiest way to workaround this issue.

Example line:

https://github.com/GoogleCloudPlatform/python-docs-samples/blob/89ad8f0a27dec5f5ca888ec1e7597ecbf0888f2c/composer/workflows/airflow_db_cleanup.py#L109C6-L109C45
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 3, 2025
@iennae
Copy link
Contributor

iennae commented Apr 4, 2025

@miguelars23 thank you for reporting this. We'll investigate.

@eapl-gemugami eapl-gemugami self-assigned this Apr 4, 2025
@eapl-gemugami eapl-gemugami mentioned this issue Apr 9, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iennae iennae

@eapl-gemugami eapl-gemugami

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(composer): fix version check logic for 'airflow_db_cleanup.py' eapl-gemugami/python-docs-samples
3 participants
@iennae @miguelars23 @eapl-gemugami