Skip to content

Update requirements.txt #13557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+4 −0
Closed

Update requirements.txt #13557

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ceeda4c
Update requirements.txt
adammil2000 Sep 4, 2025
0d15cc4
Update requirements.txt
adammil2000 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions functions/billing/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
slackclient==2.9.4
# [START functions_billing_limit_appengine_deps]
google-api-python-client==2.131.0
# [END functions_billing_limit_appengine_deps]
cloudevents==1.10.1
functions-framework==3.5.0
google-cloud-billing==1.18.1
google-cloud-logging==3.9.0
Comment on lines 5 to 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The updated dependencies are inconsistent with the imports in main.py. The existing code imports googleapiclient and slack, which are provided by google-api-python-client and slackclient respectively. These dependencies have been removed, which will cause ImportError exceptions and break the function.

The newly added dependencies (cloudevents, functions-framework, google-cloud-billing, google-cloud-logging) are not used in main.py.

Additionally, the region tags (# [START ...] and # [END ...]) have been removed. These are often important for documentation generation and code samples.

If the goal is to migrate to newer client libraries, the code in main.py must be updated as part of this PR. Otherwise, the previous dependencies should be restored to ensure the function remains operational.

slackclient==2.9.4
# [START functions_billing_limit_appengine_deps]
google-api-python-client==2.131.0
# [END functions_billing_limit_appengine_deps]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adammil2000 thanks for your contribution but this isn't going to work as expected as gemini-code-assist is sharing. What are you trying to fix?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @iennae. The changes in requirements.txt appear to be incompatible with the existing main.py file. Could you please clarify the intended purpose of this pull request, @adammil2000? Understanding the goal will help determine the correct set of dependencies and necessary code changes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this doc page:

https://cloud.google.com/billing/docs/how-to/disable-billing-with-notifications#create-cloud-run-function

we had a report from one of the devs that the libraries indicated on this page are missing these required ones (updated to use wildcards):

cloudevents==1.10.1
google-cloud-billing==1.*
google-cloud-logging==3.*

I suspect we don't need the slack dependency either.

But I am unfamiliar with the process to get these github repo samples updated so they reflect correctly in the docs. Also I don't see main.py discussed on this doc page, so that threw me a bit about what to do with that one.

Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adammil2000 Got it! Apologies for the delay. I think the problem is you want to pull this requirements file https://github.com/GoogleCloudPlatform/python-docs-samples/blob/e6d1b6c547ee4c9c115be05acc61d8f55a0b2a3c/functions/billing_stop_on_notification/requirements.txt for the documentation and not this one.