Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow constructing IVec2 in graph #1919

Open
0HyperCube opened this issue Aug 9, 2024 · 7 comments
Open

Allow constructing IVec2 in graph #1919

0HyperCube opened this issue Aug 9, 2024 · 7 comments
Labels
Good First Issue Good for newcomers Graphene Involves the node graph system/engine used by Graphite

Comments

@0HyperCube
Copy link
Member

The artboard node takes an IVec2 as the dimensions and position. Currently it is impossible to construct this in the graph.

A node taking in two f64s and constructing an IVec2 should be added.

@0HyperCube 0HyperCube added Feature Good First Issue Good for newcomers Graphene Involves the node graph system/engine used by Graphite labels Aug 9, 2024
@github-project-automation github-project-automation bot moved this to Short-Term in Task Board Aug 9, 2024
@Keavon
Copy link
Member

Keavon commented Aug 9, 2024

We should consider reusing the Vector2 node and letting the type system support casting from an IVec2 to a DVec2.

@aybdee
Copy link
Contributor

aybdee commented Sep 2, 2024

I want to try doing this to get a better understanding of how graphene works, how do you suggest i go about it ?

@Keavon
Copy link
Member

Keavon commented Sep 2, 2024

@TrueDoctor is this okay to work on right now or should it wait until your refactor in #1942 is done?

@TrueDoctor
Copy link
Member

Should be fine to do now, will probably become obsolete when we add automatic type conversions

@Keavon
Copy link
Member

Keavon commented Sep 2, 2024

In that case, @aybdee, you can just reference any of the value nodes. But if you want to wait like a week, the process of creating nodes will become much easier with that refactor mentioned above.

@aybdee
Copy link
Contributor

aybdee commented Sep 2, 2024

i think i'd wait then
i'll try some other stuff for now

@Keavon
Copy link
Member

Keavon commented Sep 2, 2024

Sounds great. There are a lot of good options in #code-todo-list on Discord, that's where most of the good beginner issues are at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers Graphene Involves the node graph system/engine used by Graphite
Projects
Status: Short-Term
Development

No branches or pull requests

4 participants