Skip to content

Outline mode stroke width inconsistent related to parent layer scale value #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EllenGYY opened this issue Mar 14, 2025 · 5 comments · Fixed by #2455
Closed

Outline mode stroke width inconsistent related to parent layer scale value #2435

EllenGYY opened this issue Mar 14, 2025 · 5 comments · Fixed by #2455
Assignees
Labels
Graphics GPU and graphics programming related
Milestone

Comments

@EllenGYY
Copy link
Contributor

If the parent layer of a vector shape has a non-1 transform scale, it will cause the outline mode rendering to have an inconsistent width.

Image

@Keavon Keavon closed this as completed Mar 14, 2025
@Keavon Keavon reopened this Mar 14, 2025
@Keavon
Copy link
Member

Keavon commented Mar 14, 2025

What is this one's relationship to #2387?

@EllenGYY
Copy link
Contributor Author

This is a separate issue. The closed issue was caused by the vector lacking a stroke node while having its own scale. This issue occurs when vectors have a parent with scaling applied. I tested it on dev.graphite.rs, and it has not been fixed yet.

@0HyperCube
Copy link
Member

@Keavon I thought that a transformation on a parent was supposed to also affect the strokes of all of the child layers?

@Keavon
Copy link
Member

Keavon commented Mar 14, 2025

@0HyperCube this is discussing the "Outline" (aka wireframe) view mode where everything should be a black hairline stroke.

@Keavon
Copy link
Member

Keavon commented Apr 7, 2025

Completed by #2455.

@Keavon Keavon closed this as completed Apr 7, 2025
@Keavon Keavon added the Graphics GPU and graphics programming related label Apr 7, 2025
@Keavon Keavon added this to Task Board Apr 7, 2025
@Keavon Keavon moved this to Completed This Milestone in Task Board Apr 7, 2025
@Keavon Keavon added this to the Milestone 47 milestone Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graphics GPU and graphics programming related
Projects
Status: Completed This Milestone
3 participants