Skip to content

Transform node rotation breaks Pen tool shapes when entered manually #2548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nirajsah opened this issue Apr 10, 2025 · 3 comments
Closed

Transform node rotation breaks Pen tool shapes when entered manually #2548

Nirajsah opened this issue Apr 10, 2025 · 3 comments

Comments

@Nirajsah
Copy link

Description:
When using the Transform node to rotate a shape created with the Pen tool by manually entering a rotation value (in degrees), the shape does not rotate in place. Instead, the shape shifts unexpectedly, and the x/y translation values appear to be misaligned. This does not happen when using the mouse-based rotation tool, which rotates the shape correctly around its centre.

Steps to Reproduce:

Draw a shape using the Pen tool.

Open the Transform node.

Manually enter a value in the rotation field (e.g. 45°).

Observe that the shape jumps to another position instead of rotating in place.

Try rotating the same shape using the canvas rotation tool with the mouse — the shape rotates correctly without changing position.

Expected Behaviour:
Shapes should rotate around their centre consistently, regardless of whether the rotation is applied manually via the UI field or interactively with the mouse.

@Keavon
Copy link
Member

Keavon commented Apr 10, 2025

This is the intended behavior because you are directly editing the object's transform, which rotates about its local origin. If you look closely, you'll see that rotating the object interactively in the viewport actually makes it update its location as well (to counteract its movement). The tools consider the layer bounding box and the yellow pivot crosshair to set the object's raw transform for you.

If you'd like to apply a rotation by a specific numerical amount, you can use the R key followed by typing the angle you'd like to rotate by.

The object's origin point is currently further from where you might expect it due to limitations of the current transform model. #1834 is presently nearing completion and will make the local origin point more meaningful and usually closer to the expected location.

This issue also made me notice that it should be possible to add a toggle for using the layer's current yellow pivot crosshair as the desired center of rotation when typing a number in the Transform node parameters; if enabled, it could apply an update to the location as well as the rotation. I'll add a note about that feature to #2225 which will directly solve your issue.

@Nirajsah
Copy link
Author

Nirajsah commented Apr 10, 2025

This is the intended behavior because you are directly editing the object's transform. which rotates about its local origin. If you look closely, you'll see that rotating the object interactively in the viewport actually makes it update its location as well (to counteract its movement). The tools consider the layer bounding box and the yellow pivot crosshair to set the object's raw transform for you.

rotating about its local origin, That makes sense, although I still don't understand the use case, it moves outside document viewport.

If you'd like to apply a rotation by a specific numerical amount, you can use the R key followed by typing the angle you'd like to rotate by.

The object's origin point is currently further from where you might expect it due to limitations of the current transform model. #1834 is presently nearing completion and will make the local origin point more meaningful and usually closer to the expected location.

This issue also made me notice that it should be possible to add a toggle for using the layer's current yellow pivot crosshair as the desired center of rotation when typing a number in the Transform node parameters; if enabled, it could apply an update to the location as well as the rotation. I'll add a note about that feature to #2225 which will directly solve your issue.

yes, having a toggle would help, beginners like me won't get confused 😅

@Keavon
Copy link
Member

Keavon commented Apr 10, 2025

I'm going to close this now that I've written about it in #2225 since this issue isn't directly actionable, but has nonetheless been useful!

@Keavon Keavon closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2025
@github-project-automation github-project-automation bot moved this from Short-Term to Completed This Milestone in Task Board Apr 10, 2025
@Keavon Keavon removed this from Task Board Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants