Skip to content

Commit 0d46ee9

Browse files
committed
remove another machine interface
1 parent c5c84e9 commit 0d46ee9

7 files changed

Lines changed: 9 additions & 44 deletions

File tree

src/main/java/com/gregtechceu/gtceu/api/block/MetaMachineBlock.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -223,12 +223,11 @@ public BlockState rotate(BlockState pState, Rotation pRotation) {
223223

224224
@Override
225225
public List<ItemStack> getDrops(BlockState state, LootParams.Builder builder) {
226-
BlockEntity tileEntity = builder.getOptionalParameter(LootContextParams.BLOCK_ENTITY);
227226
var drops = super.getDrops(state, builder);
228-
if (tileEntity instanceof MetaMachine machine) {
229-
if (machine instanceof IMachineModifyDrops machineModifyDrops) {
230-
machineModifyDrops.onDrops(drops);
231-
}
227+
228+
BlockEntity be = builder.getOptionalParameter(LootContextParams.BLOCK_ENTITY);
229+
if (be instanceof MetaMachine machine) {
230+
machine.modifyDrops(drops);
232231
if (machine instanceof IDropSaveMachine dropSaveMachine && dropSaveMachine.saveBreak()) {
233232
for (ItemStack drop : drops) {
234233
if (drop.getItem() instanceof MetaMachineItem item && item.getBlock() == this) {

src/main/java/com/gregtechceu/gtceu/api/machine/MetaMachine.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@
5151
import com.lowdragmc.lowdraglib.utils.DummyWorld;
5252

5353
import net.minecraft.ChatFormatting;
54-
import net.minecraft.MethodsReturnNonnullByDefault;
5554
import net.minecraft.client.Minecraft;
5655
import net.minecraft.client.renderer.block.BlockRenderDispatcher;
5756
import net.minecraft.client.resources.model.BakedModel;
@@ -100,10 +99,6 @@
10099
import java.util.function.Consumer;
101100
import java.util.function.Predicate;
102101

103-
import javax.annotation.ParametersAreNonnullByDefault;
104-
105-
@ParametersAreNonnullByDefault
106-
@MethodsReturnNonnullByDefault
107102
public class MetaMachine extends ManagedSyncBlockEntity implements IGregtechBlockEntity, IToolable, IToolGridHighlight,
108103
IFancyTooltip, IPaintable, IMachineFeature, ICopyable {
109104

@@ -211,6 +206,8 @@ public void onMachineDestroyed() {
211206
}
212207
}
213208

209+
public void modifyDrops(List<ItemStack> drops) {}
210+
214211
//////////////////////////////////////
215212
// ***** Tickable Manager ****//
216213
//////////////////////////////////////
@@ -279,7 +276,7 @@ private void executeTick() {
279276
//////////////////////////////////////
280277

281278
/**
282-
* Called when a player clicks this meta tile entity with a tool
279+
* Called when a player clicks this machine with a tool
283280
*
284281
* @return SUCCESS / CONSUME (will damage tool) / FAIL if something happened, so tools will get damaged and
285282
* animations will be played

src/main/java/com/gregtechceu/gtceu/api/machine/SimpleGeneratorMachine.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import net.minecraft.resources.ResourceLocation;
2424

2525
import com.google.common.collect.Tables;
26-
import com.mojang.blaze3d.MethodsReturnNonnullByDefault;
2726
import it.unimi.dsi.fastutil.ints.Int2IntFunction;
2827
import lombok.Getter;
2928
import org.jetbrains.annotations.NotNull;
@@ -33,10 +32,6 @@
3332
import java.util.LinkedHashMap;
3433
import java.util.function.BiFunction;
3534

36-
import javax.annotation.ParametersAreNonnullByDefault;
37-
38-
@ParametersAreNonnullByDefault
39-
@MethodsReturnNonnullByDefault
4035
public class SimpleGeneratorMachine extends WorkableTieredMachine
4136
implements IFancyUIMachine, IEnvironmentalHazardEmitter {
4237

src/main/java/com/gregtechceu/gtceu/api/machine/SimpleTieredMachine.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,21 +40,16 @@
4040
import net.minecraft.resources.ResourceLocation;
4141

4242
import com.google.common.collect.Tables;
43-
import com.mojang.blaze3d.MethodsReturnNonnullByDefault;
4443
import it.unimi.dsi.fastutil.ints.Int2IntFunction;
4544
import lombok.Getter;
4645
import org.jetbrains.annotations.Nullable;
4746

4847
import java.util.*;
4948
import java.util.function.*;
5049

51-
import javax.annotation.ParametersAreNonnullByDefault;
52-
5350
/**
5451
* All simple single machines are implemented here.
5552
*/
56-
@ParametersAreNonnullByDefault
57-
@MethodsReturnNonnullByDefault
5853
public class SimpleTieredMachine extends WorkableTieredMachine
5954
implements IFancyUIMachine, IHasCircuitSlot {
6055

src/main/java/com/gregtechceu/gtceu/api/machine/WorkableTieredMachine.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import com.gregtechceu.gtceu.utils.GTUtil;
1212
import com.gregtechceu.gtceu.utils.ISubscription;
1313

14-
import com.mojang.blaze3d.MethodsReturnNonnullByDefault;
1514
import it.unimi.dsi.fastutil.ints.Int2IntFunction;
1615
import lombok.Getter;
1716
import lombok.Setter;
@@ -22,10 +21,6 @@
2221
import java.util.*;
2322
import java.util.function.Function;
2423

25-
import javax.annotation.ParametersAreNonnullByDefault;
26-
27-
@ParametersAreNonnullByDefault
28-
@MethodsReturnNonnullByDefault
2924
public abstract class WorkableTieredMachine extends TieredEnergyMachine implements IRecipeLogicMachine,
3025
IMufflableMachine, IOverclockMachine {
3126

src/main/java/com/gregtechceu/gtceu/api/machine/feature/IMachineModifyDrops.java

Lines changed: 0 additions & 15 deletions
This file was deleted.

src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/part/hpca/HPCAComponentPartMachine.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import com.gregtechceu.gtceu.api.blockentity.BlockEntityCreationInfo;
44
import com.gregtechceu.gtceu.api.capability.IHPCAComponentHatch;
5-
import com.gregtechceu.gtceu.api.machine.feature.IMachineModifyDrops;
65
import com.gregtechceu.gtceu.api.machine.multiblock.part.MultiblockPartMachine;
76
import com.gregtechceu.gtceu.api.machine.property.GTMachineModelProperties;
87
import com.gregtechceu.gtceu.api.sync_system.annotations.RerenderOnChanged;
@@ -24,7 +23,7 @@
2423
@MethodsReturnNonnullByDefault
2524
@ParametersAreNonnullByDefault
2625
public abstract class HPCAComponentPartMachine extends MultiblockPartMachine
27-
implements IHPCAComponentHatch, IMachineModifyDrops {
26+
implements IHPCAComponentHatch {
2827

2928
@SaveField
3029
@SyncToClient
@@ -89,7 +88,7 @@ public void setActive(boolean active) {
8988
}
9089

9190
@Override
92-
public void onDrops(List<ItemStack> drops) {
91+
public void modifyDrops(List<ItemStack> drops) {
9392
for (int i = 0; i < drops.size(); ++i) {
9493
ItemStack drop = drops.get(i);
9594
if (drop.getItem() == this.getDefinition().getItem()) {

0 commit comments

Comments
 (0)