Skip to content

Commit 280df06

Browse files
authored
chore: add some trace logs in fetching data from cache and object store (#6877)
* chore: add some important debug logs Signed-off-by: zyy17 <[email protected]> * chore: add traces logs in `fetch_byte_ranges()` Signed-off-by: zyy17 <[email protected]> --------- Signed-off-by: zyy17 <[email protected]>
1 parent 11a08d1 commit 280df06

File tree

2 files changed

+22
-3
lines changed

2 files changed

+22
-3
lines changed

src/mito2/src/sst/parquet/helper.rs

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,10 @@
1414

1515
use std::ops::Range;
1616
use std::sync::Arc;
17+
use std::time::Instant;
1718

1819
use bytes::Bytes;
20+
use common_telemetry::trace;
1921
use object_store::ObjectStore;
2022
use parquet::basic::ColumnOrder;
2123
use parquet::file::metadata::{FileMetaData, ParquetMetaData, RowGroupMetaData};
@@ -100,7 +102,10 @@ pub async fn fetch_byte_ranges(
100102
object_store: ObjectStore,
101103
ranges: &[Range<u64>],
102104
) -> object_store::Result<Vec<Bytes>> {
103-
Ok(object_store
105+
let total_size = ranges.iter().map(|r| r.end - r.start).sum::<u64>();
106+
let start = Instant::now();
107+
108+
let result = object_store
104109
.reader_with(file_path)
105110
.concurrent(FETCH_PARALLELISM)
106111
.gap(MERGE_GAP)
@@ -109,5 +114,14 @@ pub async fn fetch_byte_ranges(
109114
.await?
110115
.into_iter()
111116
.map(|buf| buf.to_bytes())
112-
.collect::<Vec<_>>())
117+
.collect::<Vec<_>>();
118+
119+
trace!(
120+
"Fetch {} bytes from '{}' in object store, cost: {:?}",
121+
total_size,
122+
file_path,
123+
start.elapsed()
124+
);
125+
126+
Ok(result)
113127
}

src/object-store/src/layers/lru_cache/read_cache.rs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
use std::sync::Arc;
1616

17-
use common_telemetry::debug;
17+
use common_telemetry::{debug, trace};
1818
use futures::{FutureExt, TryStreamExt};
1919
use moka::future::Cache;
2020
use moka::notification::ListenerFuture;
@@ -290,6 +290,11 @@ impl<C: Access> ReadCache<C> {
290290
let (_, reader) = inner.read(path, args).await?;
291291
let result = self.try_write_cache::<I>(reader, read_key).await;
292292

293+
trace!(
294+
"Read cache miss for key '{}' and fetch file '{}' from object store",
295+
read_key, path,
296+
);
297+
293298
match result {
294299
Ok(read_bytes) => {
295300
OBJECT_STORE_LRU_CACHE_ENTRIES.inc();

0 commit comments

Comments
 (0)