Skip to content

Commit 7a8531c

Browse files
committed
removed unused SNAFU error and ran sqlness test
Signed-off-by: Kumar Ujjawal <[email protected]>
1 parent 177dc74 commit 7a8531c

File tree

6 files changed

+7
-41
lines changed

6 files changed

+7
-41
lines changed

config/config.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@
200200
| `slow_query.record_type` | String | Unset | The record type of slow queries. It can be `system_table` or `log`. |
201201
| `slow_query.threshold` | String | Unset | The threshold of slow query. |
202202
| `slow_query.sample_ratio` | Float | Unset | The sampling ratio of slow query log. The value should be in the range of (0, 1]. |
203-
| `tracing` | -- | -- | The tracing options. Only effect when compiled with `tokio-console` feature. |
203+
| `tracing` | -- | -- | Exporting internal metrics via remote-write has been removed. Please use external Prometheus/OTel/VMA to scrape metrics.<br/>The tracing options. Only effect when compiled with `tokio-console` feature. |
204204
| `tracing.tokio_console_addr` | String | Unset | The tokio console address. |
205205
| `memory` | -- | -- | The memory options. |
206206
| `memory.enable_heap_profiling` | Bool | `true` | Whether to enable heap profiling activation during startup.<br/>When enabled, heap profiling will be activated if the `MALLOC_CONF` environment variable<br/>is set to "prof:true,prof_active:false". The official image adds this env variable.<br/>Default is true. |
@@ -312,7 +312,7 @@
312312
| `slow_query.threshold` | String | `30s` | The threshold of slow query. It can be human readable time string, for example: `10s`, `100ms`, `1s`. |
313313
| `slow_query.sample_ratio` | Float | `1.0` | The sampling ratio of slow query log. The value should be in the range of (0, 1]. For example, `0.1` means 10% of the slow queries will be logged and `1.0` means all slow queries will be logged. |
314314
| `slow_query.ttl` | String | `90d` | The TTL of the `slow_queries` system table. Default is `90d` when `record_type` is `system_table`. |
315-
| `tracing` | -- | -- | The tracing options. Only effect when compiled with `tokio-console` feature. |
315+
| `tracing` | -- | -- | Exporting internal metrics via remote-write has been removed. Please use external Prometheus/OTel/VMA to scrape metrics.<br/>The tracing options. Only effect when compiled with `tokio-console` feature. |
316316
| `tracing.tokio_console_addr` | String | Unset | The tokio console address. |
317317
| `memory` | -- | -- | The memory options. |
318318
| `memory.enable_heap_profiling` | Bool | `true` | Whether to enable heap profiling activation during startup.<br/>When enabled, heap profiling will be activated if the `MALLOC_CONF` environment variable<br/>is set to "prof:true,prof_active:false". The official image adds this env variable.<br/>Default is true. |
@@ -402,7 +402,7 @@
402402
| `logging.otlp_headers` | -- | -- | Additional OTLP headers, only valid when using OTLP http |
403403
| `logging.tracing_sample_ratio` | -- | Unset | The percentage of tracing will be sampled and exported.<br/>Valid range `[0, 1]`, 1 means all traces are sampled, 0 means all traces are not sampled, the default value is 1.<br/>ratio > 1 are treated as 1. Fractions < 0 are treated as 0 |
404404
| `logging.tracing_sample_ratio.default_ratio` | Float | `1.0` | -- |
405-
| `tracing` | -- | -- | The tracing options. Only effect when compiled with `tokio-console` feature. |
405+
| `tracing` | -- | -- | Exporting internal metrics via remote-write has been removed. Please use external Prometheus/OTel/VMA to scrape metrics.<br/>The tracing options. Only effect when compiled with `tokio-console` feature. |
406406
| `tracing.tokio_console_addr` | String | Unset | The tokio console address. |
407407
| `memory` | -- | -- | The memory options. |
408408
| `memory.enable_heap_profiling` | Bool | `true` | Whether to enable heap profiling activation during startup.<br/>When enabled, heap profiling will be activated if the `MALLOC_CONF` environment variable<br/>is set to "prof:true,prof_active:false". The official image adds this env variable.<br/>Default is true. |
@@ -567,7 +567,7 @@
567567
| `logging.otlp_headers` | -- | -- | Additional OTLP headers, only valid when using OTLP http |
568568
| `logging.tracing_sample_ratio` | -- | Unset | The percentage of tracing will be sampled and exported.<br/>Valid range `[0, 1]`, 1 means all traces are sampled, 0 means all traces are not sampled, the default value is 1.<br/>ratio > 1 are treated as 1. Fractions < 0 are treated as 0 |
569569
| `logging.tracing_sample_ratio.default_ratio` | Float | `1.0` | -- |
570-
| `tracing` | -- | -- | The tracing options. Only effect when compiled with `tokio-console` feature. |
570+
| `tracing` | -- | -- | Exporting internal metrics via remote-write has been removed. Please use external Prometheus/OTel/VMA to scrape metrics.<br/>The tracing options. Only effect when compiled with `tokio-console` feature. |
571571
| `tracing.tokio_console_addr` | String | Unset | The tokio console address. |
572572
| `memory` | -- | -- | The memory options. |
573573
| `memory.enable_heap_profiling` | Bool | `true` | Whether to enable heap profiling activation during startup.<br/>When enabled, heap profiling will be activated if the `MALLOC_CONF` environment variable<br/>is set to "prof:true,prof_active:false". The official image adds this env variable.<br/>Default is true. |

src/cmd/src/error.rs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -99,13 +99,6 @@ pub enum Error {
9999
source: flow::Error,
100100
},
101101

102-
#[snafu(display("Servers error"))]
103-
Servers {
104-
#[snafu(implicit)]
105-
location: Location,
106-
source: servers::error::Error,
107-
},
108-
109102
#[snafu(display("Failed to start frontend"))]
110103
StartFrontend {
111104
#[snafu(implicit)]
@@ -315,7 +308,6 @@ impl ErrorExt for Error {
315308
Error::ShutdownFrontend { source, .. } => source.status_code(),
316309
Error::StartMetaServer { source, .. } => source.status_code(),
317310
Error::ShutdownMetaServer { source, .. } => source.status_code(),
318-
Error::Servers { source, .. } => source.status_code(),
319311
Error::BuildMetaServer { source, .. } => source.status_code(),
320312
Error::UnsupportedSelectorType { source, .. } => source.status_code(),
321313
Error::BuildCli { source, .. } => source.status_code(),

src/servers/src/error.rs

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -256,21 +256,6 @@ pub enum Error {
256256
error: std::io::Error,
257257
},
258258

259-
#[snafu(display("Failed to send prometheus remote request"))]
260-
SendPromRemoteRequest {
261-
#[snafu(implicit)]
262-
location: Location,
263-
#[snafu(source)]
264-
error: reqwest::Error,
265-
},
266-
267-
#[snafu(display("Invalid export metrics config, msg: {}", msg))]
268-
InvalidExportMetricsConfig {
269-
msg: String,
270-
#[snafu(implicit)]
271-
location: Location,
272-
},
273-
274259
#[snafu(display("Failed to compress prometheus remote request"))]
275260
CompressPromRemoteRequest {
276261
#[snafu(implicit)]
@@ -648,7 +633,6 @@ impl ErrorExt for Error {
648633
| StartHttp { .. }
649634
| StartGrpc { .. }
650635
| TcpBind { .. }
651-
| SendPromRemoteRequest { .. }
652636
| BuildHttpResponse { .. }
653637
| Arrow { .. }
654638
| FileWatch { .. } => StatusCode::Internal,
@@ -685,7 +669,6 @@ impl ErrorExt for Error {
685669
| DecompressSnappyPromRemoteRequest { .. }
686670
| DecompressZstdPromRemoteRequest { .. }
687671
| InvalidPromRemoteRequest { .. }
688-
| InvalidExportMetricsConfig { .. }
689672
| InvalidFlightTicket { .. }
690673
| InvalidPrepareStatement { .. }
691674
| DataFrame { .. }

tests/cases/standalone/common/show/show_databases_tables.result

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,3 +185,4 @@ SHOW TABLE STATUS from public;
185185
USE public;
186186

187187
Affected Rows: 0
188+

tests/cases/standalone/common/system/information_schema.result

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -782,18 +782,6 @@ SELECT * FROM CHECK_CONSTRAINTS;
782782
+--------------------+-------------------+-----------------+--------------+
783783
+--------------------+-------------------+-----------------+--------------+
784784

785-
786-
+-------------+----------------------+-----+------+---------+---------------+
787-
| Column | Type | Key | Null | Default | Semantic Type |
788-
+-------------+----------------------+-----+------+---------+---------------+
789-
| metric_name | String | | NO | | FIELD |
790-
| value | Float64 | | NO | | FIELD |
791-
| labels | String | | YES | | FIELD |
792-
| peer_addr | String | | YES | | FIELD |
793-
| peer_type | String | | NO | | FIELD |
794-
| timestamp | TimestampMillisecond | | NO | | FIELD |
795-
+-------------+----------------------+-----+------+---------+---------------+
796-
797785
DESC TABLE REGION_PEERS;
798786

799787
+---------------+--------+-----+------+---------+---------------+
@@ -852,3 +840,4 @@ Error: 4001(TableNotFound), Table not found: greptime.my_db.foo
852840
use public;
853841

854842
Affected Rows: 0
843+

tests/cases/standalone/common/view/create.result

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,3 +201,4 @@ WHERE c.relkind IN ('v','')
201201
ORDER BY 1,2;
202202

203203
Error: 4001(TableNotFound), Failed to plan SQL: Table not found: greptime.pg_catalog.pg_class
204+

0 commit comments

Comments
 (0)