Skip to content

Commit c91dd02

Browse files
committed
Delete obsolete TestSourcesPlugin
Since we have migrated to Gradle's built-in test fixture support, the custom TestSourcesPlugin Gradle plugin is now obsolete. See spring-projectsgh-23550
1 parent 7b6d83a commit c91dd02

File tree

5 files changed

+5
-148
lines changed

5 files changed

+5
-148
lines changed

buildSrc/README.md

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Spring Framework build
1+
# Spring Framework Build
22

33
This folder contains the custom plugins and conventions for the Spring Framework build.
44
They are declared in the `build.gradle` file in this folder.
@@ -7,8 +7,8 @@ They are declared in the `build.gradle` file in this folder.
77

88
### Compiler conventions
99

10-
The `org.springframework.build.compile` applies the Java compiler conventions to the build.
11-
By default, the build is compiling sources with the `1.8` source and target compatibility.
10+
The `org.springframework.build.compile` plubin applies the Java compiler conventions to the build.
11+
By default, the build compiles sources with Java `1.8` source and target compatibility.
1212
You can test a different source compatibility version on the CLI with a project property like:
1313

1414
```
@@ -25,17 +25,11 @@ but doesn't affect the classpath of dependent projects.
2525
This plugin does not provide a `provided` configuration, as the native `compileOnly` and `testCompileOnly`
2626
configurations are preferred.
2727

28-
## Test sources
29-
30-
The `org.springframework.build.test-sources` updates `testCompile` dependencies to include
31-
the test source sets of `project()` dependencies. This plugin is used in the Spring Framework build
32-
to share test utilities and fixtures amongst modules.
33-
3428
## API Diff
3529

3630
This plugin uses the [Gradle JApiCmp](https://github.com/melix/japicmp-gradle-plugin) plugin
3731
to generate API Diff reports for each Spring Framework module. This plugin is applied once on the root
38-
project and create tasks in each framework module. Unlike previous versions of this part of the build,
32+
project and creates tasks in each framework module. Unlike previous versions of this part of the build,
3933
there is no need for checking out a specific tag. The plugin will fetch the JARs we want to compare the
4034
current working version with. You can generate the reports for all modules or a single module:
4135

@@ -44,4 +38,4 @@ current working version with. You can generate the reports for all modules or a
4438
./gradlew :spring-core:apiDiff -PbaselineVersion=5.1.0.RELEASE
4539
```
4640

47-
The reports are located under `build/reports/api-diff/$OLDVERSION_to_$NEWVERSION/`.
41+
The reports are located under `build/reports/api-diff/$OLDVERSION_to_$NEWVERSION/`.

buildSrc/build.gradle

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,5 @@ gradlePlugin {
2626
id = "org.springframework.build.optional-dependencies"
2727
implementationClass = "org.springframework.build.optional.OptionalDependenciesPlugin"
2828
}
29-
testSourcesPlugin {
30-
id = "org.springframework.build.test-sources"
31-
implementationClass = "org.springframework.build.testsources.TestSourcesPlugin"
32-
}
3329
}
3430
}

buildSrc/src/main/java/org/springframework/build/testsources/TestSourcesPlugin.java

Lines changed: 0 additions & 130 deletions
This file was deleted.

gradle/spring-module.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
apply plugin: 'org.springframework.build.compile'
22
apply plugin: 'org.springframework.build.optional-dependencies'
3-
apply plugin: 'org.springframework.build.test-sources'
43
apply from: "$rootDir/gradle/publications.gradle"
54

65
jar {

integration-tests/integration-tests.gradle

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
description = "Spring Integration Tests"
22

3-
apply plugin: "org.springframework.build.test-sources"
4-
53
dependencies {
64
testCompile(project(":spring-aop"))
75
testCompile(project(":spring-beans"))

0 commit comments

Comments
 (0)