Skip to content

Commit a6b33f3

Browse files
committed
Add test for validating validity period
1 parent 1c09fe5 commit a6b33f3

File tree

3 files changed

+36
-3
lines changed

3 files changed

+36
-3
lines changed

cypress/e2e/editRoute.cy.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -269,9 +269,14 @@ describe('Route editing', () => {
269269
setValidityPeriodToForm(routeValidityStart, routeValidityEnd);
270270

271271
editRoutePage.getSaveRouteButton().click();
272-
toast.expectDangerToast(
273-
'Reitin voimassaoloaijan alku ei voi olla ennen loppua',
274-
);
272+
273+
editRoutePage.changeValidityForm.validityPeriodForm
274+
.getEndDateValidityError()
275+
.shouldBeVisible()
276+
.should(
277+
'have.text',
278+
'Päättymispäivämäärä ei voi olla ennen alkamispäivämäärää',
279+
);
275280
});
276281

277282
it(

cypress/e2e/stop-registry/stopAreaDetails.cy.ts

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -956,5 +956,29 @@ describe('Stop area details', () => {
956956
'Pysäkkialueen kopiointi tekisi ainakin yhden pysäkkialueen pysäkin kautta kulkevan reitin voimassaolon virheelliseksi.\nEnnen jatkamista muokkaa reittejä, joihin tämän pysäkkialueen pysäkit kuuluvat.',
957957
);
958958
});
959+
960+
it('should not allow copy if the end date is before the start date', () => {
961+
stopAreaDetailsPage.visit(dbIds.stopPlaceIdsByName.X0004);
962+
963+
stopAreaDetailsPage.titleRow.getActionMenu().click();
964+
stopAreaDetailsPage.titleRow.getCopyButton().click();
965+
966+
stopAreaDetailsPage.copyModal.modal().shouldBeVisible();
967+
const { form } = stopAreaDetailsPage.copyModal;
968+
969+
form.getVersionNameInput().clearAndType('E2E test copy #1');
970+
form.validity.setStartDate('2030-01-02');
971+
form.validity.setAsIndefinite(false);
972+
form.validity.setEndDate('2030-01-01');
973+
form.getSubmitButton().click();
974+
975+
form.validity
976+
.getEndDateValidityError()
977+
.shouldBeVisible()
978+
.should(
979+
'have.text',
980+
'Päättymispäivämäärä ei voi olla ennen alkamispäivämäärää',
981+
);
982+
});
959983
});
960984
});

cypress/pageObjects/ValidityPeriodForm.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,4 +50,8 @@ export class ValidityPeriodForm {
5050
}
5151
this.setEndDate(values.validityEndISODate);
5252
}
53+
54+
getEndDateValidityError() {
55+
return cy.getByTestId('ValidationError::message::validityEnd');
56+
}
5357
}

0 commit comments

Comments
 (0)