|
1 | | -<!-- Thanks for contributing to Munder Difflin! --> |
| 1 | +<!-- Thanks for contributing to Munder Difflin. |
| 2 | +
|
| 3 | + Read this line before you go further: a PR without a BEFORE and an AFTER |
| 4 | + is not reviewable and will not be merged. The `PR evidence` check runs the |
| 5 | + moment you open this and will tell you if it is missing. Keep the `Before` |
| 6 | + and `After` headings below exactly as they are — the check reads them. --> |
2 | 7 |
|
3 | 8 | ## What & why |
4 | 9 |
|
5 | | -<!-- What does this change do, and why? Link any related issue: Closes #123 --> |
| 10 | +<!-- What changed, and why it needed to. Two or three sentences beats a |
| 11 | + bullet list of file names — we can read the diff, we cannot read your |
| 12 | + reasoning. If this fixes an issue, link it: Closes #123 --> |
6 | 13 |
|
7 | 14 | ## Type of change |
8 | 15 |
|
|
12 | 19 | - [ ] Docs |
13 | 20 | - [ ] Build / CI |
14 | 21 |
|
15 | | -## Screenshots / clips |
| 22 | +## Evidence |
| 23 | + |
| 24 | +<!-- REQUIRED. Drag images or a screen recording directly under each heading — |
| 25 | + GitHub uploads them inline. Both headings must have something under them. |
| 26 | +
|
| 27 | + No visible UI? You still owe evidence. Record the failing behaviour and |
| 28 | + then the same steps passing: a terminal capture, a log diff, a test that |
| 29 | + goes from red to green. "It has no UI" is not an exemption. |
| 30 | +
|
| 31 | + Truly nothing observable, like a CI tweak or a typo? Say so in |
| 32 | + "What & why" and ask a maintainer for the `no-visual-change` label. --> |
| 33 | + |
| 34 | +### Before |
| 35 | + |
| 36 | +<!-- The problem, as it exists on main right now. --> |
| 37 | + |
| 38 | +### After |
| 39 | + |
| 40 | +<!-- The same view or the same steps, with your change applied. |
| 41 | + Same window size, same theme, same data — a reviewer should be able to |
| 42 | + flip between the two and see only what you changed. --> |
| 43 | + |
| 44 | +## How I tested it |
| 45 | + |
| 46 | +<!-- The actual steps you ran, on which OS. Not "tested locally". --> |
16 | 47 |
|
17 | | -<!-- REQUIRED for any visual change: a screenshot or short clip (before/after). --> |
| 48 | +- OS: |
| 49 | +- Steps: |
18 | 50 |
|
19 | 51 | ## Discord (optional) |
20 | 52 |
|
21 | | -<!-- If you'd like the `employee of the month` role in our Discord when this merges, |
22 | | - put your handle below. Join first so we can find you: https://discord.gg/SEDzP5ZPk5 --> |
| 53 | +<!-- For the `employee of the month` role in our Discord when this merges. |
| 54 | + Join first so we can find you: https://discord.gg/SEDzP5ZPk5 --> |
23 | 55 |
|
24 | | -Discord: |
| 56 | +Discord: |
25 | 57 |
|
26 | 58 | ## Checklist |
27 | 59 |
|
28 | | -- [ ] `npm run typecheck` passes (the de-facto CI gate). |
| 60 | +- [ ] **Before and after evidence is attached above**, under both headings. |
| 61 | +- [ ] `npm run typecheck` passes. |
| 62 | +- [ ] `npm run test:focused` passes. |
29 | 63 | - [ ] `npm run build` succeeds. |
30 | | -- [ ] Any new UI derives from `DESIGN.md` / `tokens.ts` — no ad-hoc colors, spacing, or fonts. |
31 | | -- [ ] If I added art, it's my own or compatibly licensed, and listed in `ATTRIBUTION.md`. |
32 | | -- [ ] PR is focused on a single change. |
| 64 | +- [ ] This PR is **one change**. Unrelated fixes belong in their own PR. |
| 65 | +- [ ] I read the diff myself before opening this, and there is no debug output, |
| 66 | + commented-out code, or unrelated formatting churn in it. |
| 67 | +- [ ] Any new UI derives from `DESIGN.md` / `tokens.ts` — no ad-hoc colors, |
| 68 | + spacing, or fonts. |
| 69 | +- [ ] If I added art, it's my own or compatibly licensed, and listed in |
| 70 | + `ATTRIBUTION.md`. |
0 commit comments