Skip to content

Feature: Settings dialog input validations and error handling #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
esthersoftwaredev opened this issue Apr 16, 2024 · 1 comment · Fixed by #70
Closed
1 of 2 tasks

Feature: Settings dialog input validations and error handling #67

esthersoftwaredev opened this issue Apr 16, 2024 · 1 comment · Fixed by #70
Assignees

Comments

@esthersoftwaredev
Copy link
Member

esthersoftwaredev commented Apr 16, 2024

Type of feature

✨ Feature

Current behavior

  • only blog URL typed without https:// is accepted
  • no descriptive error message causing users to think that the functionality is broken

Suggested solution

  • if the input contains https:// or / remove hose parts
  • add standard input validation and error message for empty field
  • add a query to verify that the hashnode blog exists
  • add error message if hashnode blog was not found
  • make it clear for users that the site is not broken, rather there are issues with what is given as an input

Additional context

No response

I would be willing to submit a PR to fix this issue

Copy link

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@esthersoftwaredev esthersoftwaredev changed the title Feature: Sanitize settings dialog input field to handle https:// and add an error message Feature: Settings dialog input validations and error handling Apr 16, 2024
@esthersoftwaredev esthersoftwaredev self-assigned this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant