Skip to content

Commit e7451d4

Browse files
paxcalptclaude
andauthored
chore: pin test VS Code version and add .gitignore trailing newline (#20)
Addresses review nits from #19: - Pin `version` in .vscode-test.mjs to 1.101.0 (the minimum declared in engines.vscode) instead of `stable`. Tests now run against the floor the extension claims to support, and CI is not silently affected by stable-channel VS Code updates. Verified: downloads 1.101.0 and the suite passes (2 passing, 13 pending, 0 failing). - Add the missing trailing newline to .gitignore. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 2030e1a commit e7451d4

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ CLAUDE.md
44

55
# Test runner downloads and compiled test output
66
.vscode-test/
7-
out/
7+
out/

.vscode-test.mjs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@ import { defineConfig } from '@vscode/test-cli';
33
export default defineConfig({
44
label: 'unitTests',
55
files: 'out/test/**/*.test.js',
6-
version: 'stable',
6+
// Pin to the minimum supported VS Code (matches engines.vscode in
7+
// package.json) so tests run against the floor we claim to support and
8+
// CI is not silently affected by stable-channel updates.
9+
version: '1.101.0',
710
mocha: {
811
ui: 'tdd',
912
timeout: 20000,

0 commit comments

Comments
 (0)