Merge pull request #22764 from Homebrew/reinstall-self-conflict

Skip self-conflicts during install

Author: MikeMcQuaid

Library/Homebrew/formula_installer.rb

@@ -655,6 +655,8 @@ def check_conflicts
     return unless link_keg
 
     conflicts = formula.conflicts.select do |c|
+      next false if c.name == formula.name || c.name == formula.full_name
+
       f = Formulary.factory(c.name)
     rescue TapFormulaUnavailableError
       # If the formula name is a fully-qualified name let's silently

Library/Homebrew/test/formula_installer_spec.rb

@@ -299,6 +299,20 @@ def temporary_install(formula, **options)
         expect { installer.check_conflicts }.not_to raise_error
       end
     end
+
+    it "ignores conflicts that name the formula being installed" do
+      f = formula("terraform", tap: Tap.fetch("thirdparty", "selfconflict")) do
+        T.bind(self, T.class_of(Formula))
+        url "foo-1.0"
+        conflicts_with "terraform"
+      end
+
+      expect(Formulary).not_to receive(:factory)
+
+      described_class.new(f).check_conflicts
+    ensure
+      FileUtils.rm_rf HOMEBREW_TAP_DIRECTORY/"thirdparty"
+    end
   end
 
   describe "#install_dependencies" do