stdcall and fastcall deprecated on latest nightly (rust 1.90)

[mgaertne]

retour fails to build on latest nightly rust toolchain with the following error:

Checking retour v0.4.0-alpha.3
error[E0570]: "stdcall" is not a supported ABI for the current target
   --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/retour-0.4.0-alpha.3/src/macros.rs:184:56
    |
184 |       impl_hookable!(@impl_pair ($($nm : $ty),*) (extern "stdcall"  fn($($ty),*) -> Ret));
    |                                                          ^^^^^^^^^
    |
   ::: /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/retour-0.4.0-alpha.3/src/traits.rs:28:1
    |
28  | / impl_hookable! {
29  | |   __arg_0:  A, __arg_1:  B, __arg_2:  C, __arg_3:  D, __arg_4:  E, __arg_5:  F, __arg_6:  G,
30  | |   __arg_7:  H, __arg_8:  I, __arg_9:  J, __arg_10: K, __arg_11: L, __arg_12: M, __arg_13: N
31  | | }
    | |_- in this macro invocation
    |
    = help: if you need `extern "stdcall"` on win32 and `extern "C"` everywhere else, use `extern "system"`
    = note: this error originates in the macro `impl_hookable` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0570]: "fastcall" is not a supported ABI for the current target
   --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/retour-0.4.0-alpha.3/src/macros.rs:185:56
    |
185 |       impl_hookable!(@impl_pair ($($nm : $ty),*) (extern "fastcall" fn($($ty),*) -> Ret));
    |                                                          ^^^^^^^^^^
    |
   ::: /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/retour-0.4.0-alpha.3/src/traits.rs:28:1
    |
28  | / impl_hookable! {
29  | |   __arg_0:  A, __arg_1:  B, __arg_2:  C, __arg_3:  D, __arg_4:  E, __arg_5:  F, __arg_6:  G,
30  | |   __arg_7:  H, __arg_8:  I, __arg_9:  J, __arg_10: K, __arg_11: L, __arg_12: M, __arg_13: N
31  | | }
    | |_- in this macro invocation
    |
    = note: this error originates in the macro `impl_hookable` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0570`.
error: could not compile `retour` (lib) due to 30 previous errors
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.

I was able to make it compile upon deleting the two lines in the macro definition, but not sure whether that's generally applicable.

[Hpmason]

This is related to PR #67. I haven't had a chance to go look back into and merge it. Re-running the pipeline with the newest nightly, I expect it to succeed.

[mgaertne]

The problem still persists, though, on the nightly toolchain with retour v0.4.0-alpha.3. I'm not sure whether I'm supposed to test this on a git branch version.

[phimuemue]

I am unsure if this is the same, but compiling retour with 1.89 triggers an ICE (see rust-lang/rust#145425).

[jonhermansen]

This issue effects lovely-injector in NixOS since the default Rust version was switched to 1.89.0 in NixOS/nixpkgs@dc402c1

I can confirm that the changes in #67 fix the issue for me.

EDIT: I opened NixOS/nixpkgs#441266 in the mean time.

[Hpmason]

Sorry about the delay, I've been super busy the past few months. I just pushed patch v0.4.0-alpha.4 to crates.io so you can link to that version, it has the changes from #67. I still want to at some point put more effort into the crate before pushing an actual 0.4.0, but hopefully the alpha version is enough to push past the nightly changes! Let me know if you still have issues!

[mgaertne]

Works fine. Thanks.

[Hpmason]

@phimuemue @jonhermansen
Would you guys be able to confirm that this is resolved on your end? Want to double check with you two before closing out the issue.

[phimuemue]

@Hpmason Thanks for getting in touch. Seems to work on my end.