Revert "test: add waitFor() calls in submit form tests to ensure crawler state (symfony#656)"

This reverts commit 1fb612b.

Author: HypeMC

tests/ClientTest.php

@@ -350,15 +350,10 @@ public function testSubmitForm(callable $clientFactory): void
         ]);
 
         $crawler = $client->submit($form);
+        $this->assertInstanceOf(DomCrawlerCrawler::class, $crawler);
         if ($client instanceof Client) {
-            try {
-                $crawler = $client->waitFor('#result');
-            } catch (TimeoutException) {
-                $this->markTestSkipped('Test skipped if no result after 30 seconds to prevent inconsistent fail on CI');
-            }
             $this->assertInstanceOf(Crawler::class, $crawler);
         }
-        $this->assertInstanceOf(DomCrawlerCrawler::class, $crawler);
         $this->assertSame(self::$baseUri.'/form-handle.php', $crawler->getUri());
         $this->assertSame('I1: Reclus', $crawler->filter('#result')->text(null, true));
 
@@ -368,13 +363,6 @@ public function testSubmitForm(callable $clientFactory): void
         ]);
 
         $crawler = $client->submit($form);
-        if ($client instanceof Client) {
-            try {
-                $crawler = $client->waitFor('#result');
-            } catch (TimeoutException) {
-                $this->markTestSkipped('Test skipped if no result after 30 seconds to prevent inconsistent fail on CI');
-            }
-        }
         $this->assertSame(self::$baseUri.'/form-handle.php?i1=Michel&i2=&i3=&i4=i4a', $crawler->getUri());
 
         try {
@@ -395,7 +383,7 @@ public function testSubmitForm(callable $clientFactory): void
     /**
      * @dataProvider clientFactoryProvider
      */
-    public function testSubmitFormWithValues(callable $clientFactory): void
+    public function testSubmitFormWithValues(callable $clientFactory, string $type): void
     {
         /** @var AbstractBrowser $client */
         $client = $clientFactory();
@@ -405,15 +393,10 @@ public function testSubmitFormWithValues(callable $clientFactory): void
         $crawler = $client->submit($form, [
             'i1' => 'Reclus',
         ]);
-        if ($client instanceof Client) {
-            try {
-                $crawler = $client->waitFor('#result');
-            } catch (TimeoutException) {
-                $this->markTestSkipped('Test skipped if no result after 30 seconds to prevent inconsistent fail on CI');
-            }
+        $this->assertInstanceOf(DomCrawlerCrawler::class, $crawler);
+        if (Client::class === $type) {
             $this->assertInstanceOf(Crawler::class, $crawler);
         }
-        $this->assertInstanceOf(DomCrawlerCrawler::class, $crawler);
         $this->assertSame(self::$baseUri.'/form-handle.php', $crawler->getUri());
         $this->assertSame('I1: Reclus', $crawler->filter('#result')->text(null, true));
     }