-
Notifications
You must be signed in to change notification settings - Fork 8
Description
Summary
The full Settings struct (including proxy_secret, synthetic.secret_key, handler passwords) is logged via Debug format at INFO level on every request. Synthetic ID generation logs client IP, user agent, and other PII. Integration responses (full bid payloads) are logged at debug. Logger is globally set to debug level. This is both a privacy/compliance risk and a perf/log-cost risk.
Refs
crates/fastly/src/main.rsline 42 —log::info!("Settings {settings:?}")crates/fastly/src/main.rsline 177 — logger level set to debugcrates/common/src/synthetic.rsline 99 — logs HMAC input (IP, UA)crates/common/src/synthetic.rsline 112 — logs synthetic ID detailscrates/common/src/integrations/prebid.rsline 832 — logs full bid responsecrates/common/src/integrations/aps.rsline 444 — logs APS responsecrates/common/src/integrations/adserver_mock.rsline 284 — logs mock response
Recommendation
Implement a Redacted<T> wrapper for secret fields that prints [REDACTED] in Debug/Display. Set production log level to INFO or WARN. Move payload logging to TRACE.
Context
Production readiness audit — see #396
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels