Skip to content

Commit 7fdab47

Browse files
committed
build: fix exe build script
This commit fixes the create-binaries.sh script by adding the "-t" (targets) option to explicitly specify the node versions for which the executables should be built. Because we haven't successfully published the executables in about 9 months (!), I also modified the semantic-release configuration so that we avoid the steps to build and publish the executables. If we need to add this back later, it should be relatively easy since the create-binaries.sh script is now fixed. Signed-off-by: Phil Adams <[email protected]>
1 parent 2963851 commit 7fdab47

File tree

2 files changed

+3
-16
lines changed

2 files changed

+3
-16
lines changed

.releaserc

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,12 @@
11
{
2-
"branches": "main",
2+
"branches": ["main"],
33
"debug": true,
44
"plugins": [
55
"@semantic-release/commit-analyzer",
66
"@semantic-release/release-notes-generator",
77
"@semantic-release/changelog",
88
"@semantic-release/npm",
99
"@semantic-release/git",
10-
[
11-
"@semantic-release/exec",
12-
{
13-
"publishCmd": "npm run pkg"
14-
}
15-
],
16-
[
17-
"@semantic-release/github",
18-
{
19-
"assets": [
20-
"bin/*"
21-
]
22-
}
23-
]
10+
"@semantic-release/github"
2411
]
2512
}

scripts/create-binaries.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if [[ -e "../ruleset/node_modules/@ibm-cloud" ]]; then
2424
fi
2525

2626
# Create the executables
27-
../../node_modules/.bin/pkg --out-path=./bin ./package.json
27+
../../node_modules/.bin/pkg --out-path=./bin -t node18-linux,node18-win,node18-macos ./package.json
2828

2929
# Rename the executables and set their execute bit.
3030
cd ./bin

0 commit comments

Comments
 (0)