Fix Spark timestamp_seconds function

Alchemy-item: (ID = 582) Fix Spark timestamp_seconds function commit 1/1 - bd71f7e

Author: rui-mo

velox/functions/sparksql/DateTimeFunctions.h

@@ -960,37 +960,40 @@ struct SecondsToTimestampFunction {
   VELOX_DEFINE_FUNCTION_TYPES(TExec);
 
   template <typename T>
-  FOLLY_ALWAYS_INLINE void call(out_type<Timestamp>& result, T seconds) {
+  FOLLY_ALWAYS_INLINE bool call(out_type<Timestamp>& result, T seconds) {
     if constexpr (std::is_integral_v<T>) {
       result = Timestamp(static_cast<int64_t>(seconds), 0);
+      return true;
     } else {
+      if (std::isnan(seconds)) {
+        return false;
+      }
+
       // Cast to double and check bounds to prevent ensuing overflow.
       const double secondsD = static_cast<double>(seconds);
 
       if (secondsD >= kMaxSecondsD) {
         result = Timestamp(kMaxSeconds, kMaxNanoseconds);
-        return;
-      }
-      if (secondsD <= kMinSecondsD) {
+      } else if (secondsD <= kMinSecondsD) {
         result = Timestamp(kMinSeconds, kMinNanoseconds);
-        return;
-      }
-
-      // Scale to microseconds and truncate toward zero.
-      const double microsD = secondsD * Timestamp::kMicrosecondsInSecond;
-      const int64_t micros = static_cast<int64_t>(microsD);
-
-      // Split into whole seconds and remaining microseconds.
-      int64_t wholeSeconds = micros / util::kMicrosPerSec;
-      int64_t remainingMicros = micros % util::kMicrosPerSec;
-      if (remainingMicros < 0) {
-        wholeSeconds -= 1;
-        remainingMicros += util::kMicrosPerSec;
+      } else {
+        // Scale to microseconds and truncate toward zero.
+        const double microsD = secondsD * Timestamp::kMicrosecondsInSecond;
+        const int64_t micros = static_cast<int64_t>(microsD);
+
+        // Split into whole seconds and remaining microseconds.
+        int64_t wholeSeconds = micros / util::kMicrosPerSec;
+        int64_t remainingMicros = micros % util::kMicrosPerSec;
+        if (remainingMicros < 0) {
+          wholeSeconds -= 1;
+          remainingMicros += util::kMicrosPerSec;
+        }
+
+        const int64_t nano =
+            remainingMicros * Timestamp::kNanosecondsInMicrosecond;
+        result = Timestamp(wholeSeconds, nano);
       }
-
-      const int64_t nano =
-          remainingMicros * Timestamp::kNanosecondsInMicrosecond;
-      result = Timestamp(wholeSeconds, nano);
+      return true;
     }
   }