Skip to content

Commit f87f435

Browse files
committed
Pushdown integer upcasts to scan
1 parent d8a7a5e commit f87f435

File tree

11 files changed

+1182
-46
lines changed

11 files changed

+1182
-46
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ option(VELOX_ENABLE_HIVE_CONNECTOR "Build Hive connector." ON)
140140
option(VELOX_ENABLE_TPCH_CONNECTOR "Build TPC-H connector." ON)
141141
option(VELOX_ENABLE_TPCDS_CONNECTOR "Build TPC-DS connector." ON)
142142
option(VELOX_ENABLE_PRESTO_FUNCTIONS "Build Presto SQL functions." ON)
143-
option(VELOX_ENABLE_SPARK_FUNCTIONS "Build Spark SQL functions." ON)
143+
option(VELOX_ENABLE_SPARK_FUNCTIONS "Build Spark SQL functions." OFF)
144144
option(VELOX_ENABLE_ICEBERG_FUNCTIONS "Build Iceberg functions." ON)
145145
option(VELOX_ENABLE_EXPRESSION "Build expression." ON)
146146
option(

velox/core/Expressions.h

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -273,6 +273,15 @@ class FieldAccessTypedExpr : public ITypedExpr {
273273
const std::string& name() const {
274274
return name_;
275275
}
276+
//
277+
// void setName(const std::string& newName) {
278+
// name_ = newName;
279+
// }
280+
//
281+
// void updateNewType(const std::string& newName, TypePtr newType) {
282+
// name_ = newName;
283+
// type_= newType;
284+
// }
276285

277286
TypedExprPtr rewriteInputNames(
278287
const std::unordered_map<std::string, TypedExprPtr>& mapping)

velox/core/ITypedExpr.h

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,18 @@ class ITypedExpr : public ISerializable {
5252
ExprKind kind() const {
5353
return kind_;
5454
}
55+
//
56+
// virtual const std::string& name() const {
57+
// VELOX_UNSUPPORTED("name() is not supported for this expression");
58+
// }
5559

5660
const TypePtr& type() const {
5761
return type_;
5862
}
63+
//
64+
// void setType(const TypePtr& newType) {
65+
// type_.reset(newType.get());
66+
// }
5967

6068
const std::vector<TypedExprPtr>& inputs() const {
6169
return inputs_;

0 commit comments

Comments
 (0)