Skip to content

Commit c859674

Browse files
committed
updated exercise to include git pull before push; updated broken image link
1 parent 711d76a commit c859674

File tree

1 file changed

+12
-35
lines changed

1 file changed

+12
-35
lines changed

collaboration-exercise.ipynb

+12-35
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,7 @@
5858
"cell_type": "code",
5959
"execution_count": null,
6060
"metadata": {
61-
"collapsed": true,
62-
"jupyter": {
63-
"outputs_hidden": true
64-
}
61+
"collapsed": true
6562
},
6663
"outputs": [],
6764
"source": [
@@ -85,10 +82,7 @@
8582
"cell_type": "code",
8683
"execution_count": null,
8784
"metadata": {
88-
"collapsed": true,
89-
"jupyter": {
90-
"outputs_hidden": true
91-
}
85+
"collapsed": true
9286
},
9387
"outputs": [],
9488
"source": [
@@ -109,10 +103,7 @@
109103
"cell_type": "code",
110104
"execution_count": null,
111105
"metadata": {
112-
"collapsed": true,
113-
"jupyter": {
114-
"outputs_hidden": true
115-
}
106+
"collapsed": true
116107
},
117108
"outputs": [],
118109
"source": [
@@ -142,10 +133,7 @@
142133
"cell_type": "code",
143134
"execution_count": null,
144135
"metadata": {
145-
"collapsed": true,
146-
"jupyter": {
147-
"outputs_hidden": true
148-
}
136+
"collapsed": true
149137
},
150138
"outputs": [],
151139
"source": [
@@ -158,10 +146,7 @@
158146
"cell_type": "code",
159147
"execution_count": null,
160148
"metadata": {
161-
"collapsed": true,
162-
"jupyter": {
163-
"outputs_hidden": true
164-
}
149+
"collapsed": true
165150
},
166151
"outputs": [],
167152
"source": [
@@ -183,10 +168,7 @@
183168
"cell_type": "code",
184169
"execution_count": null,
185170
"metadata": {
186-
"collapsed": true,
187-
"jupyter": {
188-
"outputs_hidden": true
189-
}
171+
"collapsed": true
190172
},
191173
"outputs": [],
192174
"source": [
@@ -204,10 +186,7 @@
204186
"cell_type": "code",
205187
"execution_count": null,
206188
"metadata": {
207-
"collapsed": true,
208-
"jupyter": {
209-
"outputs_hidden": true
210-
}
189+
"collapsed": true
211190
},
212191
"outputs": [],
213192
"source": [
@@ -220,7 +199,7 @@
220199
"cell_type": "markdown",
221200
"metadata": {},
222201
"source": [
223-
"The above command will never complete when run in the iPython notebook, because running git push will prompt for your git username and password, which the jupyter notebook can't pass thru... but you can run it on a console, and enter your info from the prompt."
202+
"The above command will generally not complete when run in the iPython notebook, because running git push will prompt for your git username and password, which the jupyter notebook can't pass thru... but you can run it on a console, and enter your info from the prompt."
224203
]
225204
},
226205
{
@@ -250,14 +229,15 @@
250229
"cell_type": "markdown",
251230
"metadata": {},
252231
"source": [
253-
"Generally, it's best practice to create a new branch for the feature you're adding of the bug that you are fixing. This is so that you can work on multiple seperate features if you'd like. Say for example, you're working on a new algorithm that will take several months to finish...but have a smaller change you want to make (and push) in the meantime. For now, we'll just branch to our github user name: \n",
232+
"Generally, it's best practice to create a new branch for the feature you're adding of the bug that you are fixing. This is so that you can work on multiple seperate features if you'd like. Say for example, you're working on a new algorithm that will take several months to finish...but have a smaller change you want to make (and push) in the meantime. For now, we'll just branch to our github user name--note that we git pull before git pushing, to make sure we're on the most recent version of the repo. \n",
254233
"\n",
255234
"```\n",
256235
"git branch espg\n",
257236
"git checkout espg\n",
258237
"touch espg.txt\n",
259238
"git add espg.txt\n",
260239
"git commit -m \"changed files\"\n",
240+
"git pull\n",
261241
"git push\n",
262242
"```"
263243
]
@@ -276,7 +256,7 @@
276256
"\n",
277257
"*Mark down interface*\n",
278258
"\n",
279-
"![PR Form](images/PR_Form.png)\n",
259+
"![PR Form](images/PR_form.png)\n",
280260
"\n",
281261
"This **PR** workflow is actually pretty common, since it puts a review step in place--it's how the tutorials you're using were put together by the instructors. Once the repo owners who have read/write access decide, your code is merged. Until then, you can see your pull request listed on *their* repo, and other people can comment and view your work. \n",
282262
"\n",
@@ -320,10 +300,7 @@
320300
"cell_type": "code",
321301
"execution_count": null,
322302
"metadata": {
323-
"collapsed": true,
324-
"jupyter": {
325-
"outputs_hidden": true
326-
}
303+
"collapsed": true
327304
},
328305
"outputs": [],
329306
"source": []

0 commit comments

Comments
 (0)