Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current pcap draft doesn't include all the link types #102

Closed
kayoub5 opened this issue Dec 26, 2020 · 4 comments
Closed

Current pcap draft doesn't include all the link types #102

kayoub5 opened this issue Dec 26, 2020 · 4 comments

Comments

@kayoub5
Copy link

kayoub5 commented Dec 26, 2020

The current list of link types contains about 128 link types, unfortunately the list there is incomplete.

The additional 90 or so link types already defined in pcap-common.c needs to be taken into consideration to prevent conflict.

@guyharris
Copy link
Collaborator

The additional 90 or so link types already defined in pcap-common.c needs to be taken into consideration to prevent conflict.

Values in the range DLT_MATCHING_MIN to DLT_MATCHING_MAX, from pcap/dlt.h, are not available for assignment.

We can add "reserved for" entries for the ones that don't have specifications.

@kayoub5
Copy link
Author

kayoub5 commented Dec 27, 2020

Sounds good.

One small detail, DLT_MATCHING_MAX will soon change due to the-tcpdump-group/libpcap#934

guyharris added a commit that referenced this issue Dec 27, 2020
Add LINKTYPE_ values that aren't on the tcpdump.org site's page; most of
them are marked as reserved, as people requested them but didn't supply
any specification.

List the range 11-49 as not to be used.  This is to avoid some values
that were assigned to different DLT_ types on different platforms and to
avoid cases where those values might be assigned to DLT_ type in the
future.  (*If* a value is assigned only to one DLT_ type, we could
consider using that value for a corresponding LINKTYPE_, as long as we
can be assured that nobody else will use that value for another
purpose.)

List the range 52-98 as not to be used.  We started assigning values at
100, to avoid both the former problem and to avoid NetBSD assigning
additional values from that range.

While we're at it, note that LINKTYPE_ARCNET_BSD is for ARCNET packets
with BSD's encapsulation (as opposed to Linux's encapsulation).

It Would Be Nice if those who requested these values would supply a
specification; if those types are dissected by tcpdump, Wireshark, or
any other existing software, that specification must match what that
software dissects.

Fixes GitHub issue #102.
@guyharris
Copy link
Collaborator

They should be there now. Some ranges are marked as "not to be used".

@mcr
Copy link
Collaborator

mcr commented Dec 27, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants