Migration from outdated Leaflet.draw library to an actively maintained fork

[modos189]

Current situation

IITC-CE uses the Leaflet.draw library, which has not been updated for 7 years. PR #813 proposes adding a confirmation when deleting all layers using the following code:

// Add Confirm request to Delete-All command
var original = L.EditToolbar.Delete.prototype.removeAllLayers;
L.EditToolbar.Delete.prototype.removeAllLayers = function () {
  if (confirm('Are you sure?')) {
    original.call(this);
  }
};

Problem

This approach involves direct modification of library methods in the IITC-CE code, which is not an optimal solution in terms of long-term code maintenance and may cause problems when updating the library.

Proposed solution

It is necessary to:

1. Research existing forks of the Leaflet.draw library and choose an actively maintained option
2. Or create our own fork of the library if no suitable one is found
3. Transfer the changes proposed in PR drawtools: add delete confirmation dialog #813 to the selected/created fork
4. Update dependencies in IITC-CE to use the new library instead of the outdated one

[DanielOndiordna]

Good idea, but I would propose to add an override option:

// Add Confirm request to Delete-All command
var original = L.EditToolbar.Delete.prototype.removeAllLayers;
L.EditToolbar.Delete.prototype.removeAllLayers = function (autoconfirm = false) {
if (autoconfirm || confirm('Are you sure?')) {
original.call(this);
}
};

[McBen]

Good idea, but I would propose to add an override option:

I think you are referring to: #813
I added a paramterless alternativ: removeAllLayersDirect even if I had no idea why anybody would call L.EditToolbar.Delete.removeAllLayersDirect()

[McBen]

OnTopic:
https://github.com/geoman-io/leaflet-geoman is a good replacment.

But it would be like a DT-Plugin rewrite from scratch. And require the same monkey-patching to match IITC requierments as it now does with DrawTools.
( like for: geodesic geometry and snapping)