-
Notifications
You must be signed in to change notification settings - Fork 30
BUG - GLOWS L2 calibration expects incorrect structure #2932
Copy link
Copy link
Open
Labels
Ins: GLOWSRelated to the GLOWS instrumentRelated to the GLOWS instrumentLevel: L2Level 2 processingLevel 2 processingbugSomething isn't workingSomething isn't working
Milestone
Description
Description of the issue
The L2 calibration that is applied to flux calculations expects an incorrect structure of the input calibration dataset which breaks the process for parsing the calibration factor needed.
Expected vs Actual behavior
Expected structure:
xr.Dataset with coordinate "start_time_utc" and data variable "cps_per_r"
Actual structure:
xr.Dataset with:
Dimensions: (epoch: 70,
start_time_utc_dim_0: 121,
cps_per_r_dim_0: 121)
Coordinates:
* epoch (epoch) datetime64[s]
Data variables:
start_time_utc (epoch, start_time_utc_dim_0) <U19
cps_per_r (epoch, cps_per_r_dim_0) float64
input_file_version (epoch) float64
Each epoch has the same start_time_utc and cps_per_r values and epoch doesn't necessarily match start_time_utc in size or values
@maxinelasp is this the intended structure for calibration data? This is created by the GlowsAncillaryCombiner
Fix
- Return
GlowsAncillaryCombiner.convert_file_to_datasetrelated to thel2-calibrationfile type to how it was prior to recent PR (Glows L2 - Apply calibration #2918 ) that applied calibration since there is further processing of the xarray dataset downstream that were unclear before the change. - Update
glows_l2_data.HistogramL2.get_calibration_datato correctly parse the calibration dataset - Update related tests
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Ins: GLOWSRelated to the GLOWS instrumentRelated to the GLOWS instrumentLevel: L2Level 2 processingLevel 2 processingbugSomething isn't workingSomething isn't working
Type
Projects
Status
In Progress