Added validator on person's userid

Author: chris-adam

CHANGES.rst

@@ -20,6 +20,8 @@ Changelog
   [sgeulette]
 - Added 'imio.annex' and iconified categories to dms files and dms appendix files.
   [sgeulette, chris-adam]
+- Added validator on person's userid.
+  [chris-adam]
 
 3.0 (2021-09-30)
 ----------------

imio/dms/mail/content/behaviors.py

@@ -1,5 +1,6 @@
 # -*- coding: utf-8 -*-
 from collective.contact.plonegroup import _ as _ccp
+from collective.contact.plonegroup.behaviors import IPlonegroupUserLink
 from collective.z3cform.datagridfield import DataGridFieldFactory
 from collective.z3cform.datagridfield.registry import DictRow
 from dexterity.localrolesfield.field import LocalRoleField
@@ -10,6 +11,7 @@
 from imio.dms.mail.utils import vocabularyname_to_terms
 from imio.helpers.content import uuidToObject
 from operator import itemgetter
+from plone import api
 from plone.autoform import directives as form
 from plone.autoform.interfaces import IFormFieldProvider
 from plone.supermodel import directives
@@ -208,3 +210,50 @@ def validate_signing(data):
                 raise Invalid(_(u"You cannot have empty and defined approvings at the same time !"))
             if data.seal and not data.esign:
                 raise Invalid(_(u"You cannot have a seal without electronic signature !"))
+
+
+@provider(IFormFieldProvider)
+class IImioPlonegroupUserLink(IPlonegroupUserLink):
+    @invariant
+    def validate_userid(data):
+        context = data.__context__
+        if not hasattr(context, 'userid') or getattr(context, 'userid', None) is None:
+            return
+
+        # Raise if trying to remove an existing userid
+        if data.userid is None:
+            raise Invalid(_(u"You cannot remove a userid once it is set."))
+
+        # Raise if changing userid but user has pending esign approvals
+        if data.userid != context.userid:
+            catalog = api.portal.get_tool('portal_catalog')
+
+            # Get person(s) with approving held positions for the user
+            hps = catalog.unrestrictedSearchResults(
+                portal_type='held_position',
+                userid=context.userid,
+            )
+            approving_persons = set()
+            for b in hps:
+                hp = b.getObject()
+                if 'signer'in hp.usages or 'approving' in hp.usages:
+                    approving_persons.add(hp.get_person().UID())
+
+            # Get all persons with pending esign approvals
+            mails = catalog.unrestrictedSearchResults(
+                portal_type='dmsoutgoingmail',
+                review_state='to_approve',
+            )
+            pending_approvings = set()
+            for b in mails:
+                mail = b.getObject()
+                signers = mail.signers
+                for signer in signers:
+                    for approving in signer.get('approvings', []):
+                        if approving == "_themself_":
+                            pending_approvings.add(uuidToObject(signer.get('signer'), unrestricted=True).get_person().UID())
+                        else:
+                            pending_approvings.add(approving)
+
+            if approving_persons.intersection(pending_approvings):
+                raise Invalid(_(u"You cannot change the userid because the user has pending esign approvals."))

imio/dms/mail/content/configure.zcml

@@ -4,6 +4,8 @@
     xmlns:zcml="http://namespaces.zope.org/zcml"
     i18n_domain="imio.dms.mail">
 
+    <include package="z3c.unconfigure" file="meta.zcml" />
+
     <include package="plone.behavior" file="meta.zcml" />
 
     <include package="plone.directives.form" file="meta.zcml" />
@@ -40,4 +42,18 @@
         provides=".behaviors.ISigningBehavior"
         />
 
+    <unconfigure package="collective.contact.plonegroup">
+        <plone:behavior
+            title="Plonegroup user link"
+            description="Adds user related fields"
+            provides="collective.contact.plonegroup.behaviors.IPlonegroupUserLink"
+            />
+    </unconfigure>
+
+    <plone:behavior
+        title="Plonegroup user link"
+        description="Adds user related fields"
+        provides=".behaviors.IImioPlonegroupUserLink"
+        />
+
 </configure>

imio/dms/mail/migrations/migrate_to_3_1.py

@@ -86,6 +86,7 @@ def run(self):
 
             # signing
             self.runProfileSteps("imio.dms.mail", steps=["catalog", "plone.app.registry"])
+            load_type_from_package("person", "imio.dms.mail:default")  # behavior
             load_type_from_package("dmsoutgoingmail", "profile-imio.dms.mail:default")  # behavior
             load_type_from_package("held_position", "profile-imio.dms.mail:default")  # behavior
             load_type_from_package("dmsappendixfile", "profile-imio.dms.mail:default")  # iconified

imio/dms/mail/profiles/default/types/person.xml

@@ -3,6 +3,6 @@
  <property name="global_allow">True</property>
  <property name="behaviors" purge="False">
   <element value="plone.app.lockingbehavior.behaviors.ILocking" />
-  <element value="collective.contact.plonegroup.behaviors.IPlonegroupUserLink" />
+  <element value="imio.dms.mail.content.behaviors.IImioPlonegroupUserLink" />
  </property>
 </object>