Skip to content
This repository has been archived by the owner on Aug 28, 2019. It is now read-only.

Setup CI #24

Open
10 of 15 tasks
odeimaiz opened this issue Nov 21, 2017 · 5 comments
Open
10 of 15 tasks

Setup CI #24

odeimaiz opened this issue Nov 21, 2017 · 5 comments
Assignees
@pcrespov @sbenkler

Comments

@odeimaiz
Copy link
Member

odeimaiz commented Nov 21, 2017 •
edited by sbenkler
Loading

  • Check merged w/o conflict (this is already in place by GitHub)
  • CI is triggered (via travis)
  • Use ctest to have a test scheduler (done as toplevel test-only cmake project)
  • Check repo rules in demos folder (checking readme.md and Makefile's target right now ... extendable via Python file)
  • Check Python file's PEP8 compatibility (done for Python files in ./tools)
  • C++ test coverage test (concept proof in demos/cpp-ci)
  • Building with a build-container and having a (possibly smaller) deploy container (demonstrated in demos/cpp-ci)
  • C++ coding guidelines (check and implement clang-format tool)
  • .js linter case (e.g., check and implement via clang-format tool)
  • Merge is blocked when CI fails (not to spread test failures across forks)
  • Adapt Makefile based demos
  • Run tests (those registered in top-level ctest environment)
  • triggered total/partially using a keyword in the review chat always triggered automatically via travis and a commit to the fork's feature branch
  • nice to have: monitor build times (partial and total)?
  • Add hint documents/comments when a coding guideline, linter, ... fails to have it fixed as automatic as possible

Original introduction text

The goal is to support reviews (in terms of quality & speed) of pull-requests. Therefore CI should NOT be a complete no-go as we had in pulse. Instead we should think of it as a way to evaluate (kind of a metric) and then a human can take a final informed decision. For that we would need to explore the possibility to

  • triggered total/partially using a keyword in the review chat
  • define a metric for each item
  • set optional items when triggered a revision of a pull-request
@odeimaiz
Copy link
Member Author

odeimaiz commented Nov 21, 2017 •
edited
Loading

Add Lint to Continuous Integration

@odeimaiz odeimaiz self-assigned this Nov 21, 2017
@pcrespov pcrespov assigned sbenkler and pcrespov and unassigned odeimaiz Nov 28, 2017
@oetiker
Copy link
Member

oetiker commented Nov 28, 2017

I would suggest to set it up such that whenever creates a PR, ALL the test are run and merging is blocked until all tests succeed

@pcrespov
Copy link
Member

Yep!

sbenkler pushed a commit to sbenkler/osparc-lab that referenced this issue Dec 5, 2017
Setup CI ITISFoundation#24
36ee93d 
- added initial test to check for file existance
sbenkler pushed a commit to sbenkler/osparc-lab that referenced this issue Dec 5, 2017
Setup CI ITISFoundation#24
1ccf922 
- added check of targets within Makefile ... not final, needs to make sure, they make sense to be always present
sbenkler pushed a commit to sbenkler/osparc-lab that referenced this issue Dec 5, 2017
Setup CI ITISFoundation#24
b9a4802 
- added comments to check scripts
- with Odei, added a makefile to vue
sbenkler pushed a commit to sbenkler/osparc-lab that referenced this issue Dec 5, 2017
Setup CI ITISFoundation#24
eb9fab7 
- fixing wrong path in travis.yml file
sbenkler pushed a commit to sbenkler/osparc-lab that referenced this issue Dec 5, 2017
Setup CI ITISFoundation#24
5f1c634 
- tried to capitalize the naming (Linux is case sensitive but I commit from Windows here)
sbenkler pushed a commit to sbenkler/osparc-lab that referenced this issue Dec 5, 2017
Setup CI ITISFoundation#24
17fcad4 
- after synchronizing with main repo, these two were added ... Manuel suggested to add a dummy empty make file
sbenkler pushed a commit to sbenkler/osparc-lab that referenced this issue Dec 5, 2017
Setup CI ITISFoundation#24
aa513cb 
- try to fulfill Pedro's wishes :)
sbenkler pushed a commit to sbenkler/osparc-lab that referenced this issue Dec 5, 2017
Setup CI ITISFoundation#24
56a88bb 
- fixing Python 3.6 issue
@pcrespov
Copy link
Member

pcrespov commented Dec 6, 2017

  • adding ctest as front interface for testing
  • pylint for code analysis
  • Steps to introduce guidelines:
    • human readable doc with guidelines
    • tool to check coding conventions
    • tool to assist/convert your code to fullfill guidelines

sbenkler pushed a commit to sbenkler/osparc-lab that referenced this issue Dec 6, 2017
Setup CI ITISFoundation#24
46441ad 
- converted test scripts into a ctest project
sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 8, 2017
@sbenkler
Setup CI ITISFoundation#24
8649115 
- added PEP8 Python coding convention script
- adapted demos-folder-file-structure script to fulfill pep8
sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 8, 2017
@sbenkler
Setup CI ITISFoundation#24
3ecbd25 
- autopep8-ed all Python scripts
- still is not pep8 compatible
sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 8, 2017
@sbenkler
Setup CI ITISFoundation#24
04441a4 
- disabling PEP8 tests on demos folder due to too many incompatibilities
sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 8, 2017
@sbenkler
Setup CI ITISFoundation#24
4a2e02b 
- fixing too long lines
sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 8, 2017
@sbenkler
Setup CI ITISFoundation#24
116dc42 
- so picky! The first comment line ended with a space ...
@pcrespov
Copy link
Member

pcrespov commented Dec 13, 2017 •
edited
Loading

Daily input:

  • js linter?
  • Can we setup CI in-house and/or locally in your system?

sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 13, 2017
@sbenkler
Setup CI ITISFoundation#24
f0fde32 
- added code coverge test for C++
sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 13, 2017
@sbenkler
Setup CI ITISFoundation#24
00ca17e 
- added clang packages to travis
sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 13, 2017
@sbenkler
Setup CI ITISFoundation#24
743ae3d 
- seems that travis does not contain packages clang-tidy and clang-format
sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 13, 2017
@sbenkler
Setup CI ITISFoundation#24
f982c97 
- fixes the scripts for Ubuntu 16.04 instead of 17.04
sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 13, 2017
@sbenkler
Setup CI ITISFoundation#24
03301cf 
- next trial to setup travis correctly
sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 18, 2017
@sbenkler
Setup CI ITISFoundation#24
3952b9e 
- started setting up the within-docker-build build process
sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 20, 2017
@sbenkler
Setup CI ITISFoundation#24
3b8103c 
- fixing the within-docker script: chown and reconfiguration for clang->gcc
sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 20, 2017
@sbenkler
Setup CI ITISFoundation#24
a6dcc10 
- implemented the creation of docker images (build and deploy)
sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 20, 2017
@sbenkler
Setup CI ITISFoundation#24
23bbe21 
- harmonized folder naming
sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 20, 2017
@sbenkler
Setup CI ITISFoundation#24
8ec1be7 
- adapted path namings in scripts and cmake
- added cpp-ci demos to the ctest environment
sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 20, 2017
@sbenkler
Setup CI ITISFoundation#24
34e04c3 
- try to cleanup travis description
sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 20, 2017
@sbenkler
Setup CI ITISFoundation#24
2cb048f 
- try to add docker service to travis
sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 20, 2017
@sbenkler
Setup CI ITISFoundation#24
47d5537 
- fixed pylint problem (at least locally)
- removed debug output
sbenkler added a commit to sbenkler/osparc-lab that referenced this issue Dec 20, 2017
@sbenkler
Setup CI ITISFoundation#24
4bd50d2 
- adapted image naming convention
- extended the readme
sbenkler pushed a commit to sbenkler/osparc-lab that referenced this issue Dec 21, 2017
Setup CI ITISFoundation#24
776118c 
- implement Pedro's proposal of a subfolder in tools
sbenkler added a commit that referenced this issue Dec 21, 2017
@sbenkler
Setup CI #24 (#40)
548c066 
* Setup CI #24
- added code coverge test for C++

* Setup CI #24
- added clang packages to travis

* Setup CI #24
- seems that travis does not contain packages clang-tidy and clang-format

* Setup CI #24
- fixes the scripts for Ubuntu 16.04 instead of 17.04

* Setup CI #24
- next trial to setup travis correctly

* Setup CI #24
- started setting up the within-docker-build build process

* Setup CI #24
- fixing the within-docker script: chown and reconfiguration for clang->gcc

* Setup CI #24
- implemented the creation of docker images (build and deploy)

* Setup CI #24
- harmonized folder naming

* Setup CI #24
- adapted path namings in scripts and cmake
- added cpp-ci demos to the ctest environment

* Setup CI #24
- try to cleanup travis description

* Setup CI #24
- try to add docker service to travis

* Setup CI #24
- fixed pylint problem (at least locally)
- removed debug output

* Setup CI #24
- adapted image naming convention
- extended the readme

* Setup CI #24
- implement Pedro's proposal of a subfolder in tools
pcrespov pushed a commit that referenced this issue Dec 21, 2017
@sbenkler @pcrespov
Adding CODEOWNERS file (#46)
25682db 
* Setup CI #24
- added code coverge test for C++

* Setup CI #24
- added clang packages to travis

* Setup CI #24
- seems that travis does not contain packages clang-tidy and clang-format

* Setup CI #24
- fixes the scripts for Ubuntu 16.04 instead of 17.04

* Setup CI #24
- next trial to setup travis correctly

* Setup CI #24
- started setting up the within-docker-build build process

* Setup CI #24
- fixing the within-docker script: chown and reconfiguration for clang->gcc

* Setup CI #24
- implemented the creation of docker images (build and deploy)

* Setup CI #24
- harmonized folder naming

* Setup CI #24
- adapted path namings in scripts and cmake
- added cpp-ci demos to the ctest environment

* Setup CI #24
- try to cleanup travis description

* Setup CI #24
- try to add docker service to travis

* Setup CI #24
- fixed pylint problem (at least locally)
- removed debug output

* Setup CI #24
- adapted image naming convention
- extended the readme

* Setup CI #24
- implement Pedro's proposal of a subfolder in tools

* Adding a CODEOWNERS file in the root directory

* Removed Manuel's email address according to Pedro's bad experience
odeimaiz pushed a commit to odeimaiz/oSPARC_Test that referenced this issue Feb 2, 2018
qx-py-s4l boilerplate ITISFoundation#24:
f4d4920 
- Hello world button in qooxdoo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pcrespov pcrespov

@sbenkler sbenkler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@oetiker @pcrespov @odeimaiz @sbenkler