Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform the timedelta format in ENV vars #6791

Closed
3 tasks done
giancarloromeo opened this issue Nov 21, 2024 · 0 comments · Fixed by #6797
Closed
3 tasks done

Uniform the timedelta format in ENV vars #6791

giancarloromeo opened this issue Nov 21, 2024 · 0 comments · Fixed by #6797
Assignees
Labels
t:maintenance Some planned maintenance work
Milestone

Comments

@giancarloromeo
Copy link
Contributor

giancarloromeo commented Nov 21, 2024

Context & Motivation

Pydantic v2 changed the accepted str format for datetime and timedelta (compared to v1).

Current status

In ENV vars, timings have different formats and sometimes, without knowing the implementation, it's not easy to understand if we are talking about seconds, mins, hours or days from simple scalar numbers.

Action

Uniform all the intervals, timeouts etc. to a standard format.

Legenda:

🚨 BREAKING CHANGE
⚠️ WARNING

DYNAMIC_SIDECAR_API_SAVE_RESTORE_STATE_TIMEOUT 🚨

After migration to Pydantic v2, it's a dt.timedelta instead of PositiveInt.

Ops-Config

PROJECTS_INACTIVITY_INTERVAL ⚠️

Currently, the ENV var represents seconds and is implicitily validated against timedelta but with a warning.

Ops-Config:

ENV vars that need changes

Preview Give feedback
  1. giancarloromeo
  2. a:clusters-keeper
    giancarloromeo
@giancarloromeo giancarloromeo added the t:maintenance Some planned maintenance work label Nov 21, 2024
@giancarloromeo giancarloromeo changed the title Uniform the timedelta settings Uniform the timedelta format in settings Nov 21, 2024
@giancarloromeo giancarloromeo changed the title Uniform the timedelta format in settings Uniform the timedelta format in ENV vars Nov 21, 2024
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants