Page objects after (#5)

kurenn · web-flow · commit 8f0bf37e6ab1 · 2020-02-28T17:30:09.000-06:00
* Adds product scaffold

* Adds product system spec setup

* Adds simple product system specs to refactor

* Improves the test for product

* Improves the specs to better handle the product publishing

* Refactors the product spec file with a page object for product creation

* Refactors the publish spec to page object

* Moves the page class definition to a file

* Adds assignment on README
diff --git a/.bash_history b/.bash_history
@@ -35,3 +35,5 @@ exit
 export
 #!/bin/bash -i
 export
+#!/bin/bash -i
+export
diff --git a/README.md b/README.md
@@ -14,7 +14,7 @@ This repository will hold all of the exercises for the Advanced Testing Techniqu
 
 ## Assignments
 
-You assignment for this will be to go to a local repository, legacy project or something you are currently working on, and refactor using one of this techniques. After that create a PR and assign it to @kurenn @vovimayhem @miguejs on github.
+You assignment for this, will be to refactor some system specs you have than can use this pattern, you know you have some!, refactor them, and place PR assigned to anyone from tech, @vovimayhem @miguejs or @kurenn.
 
 Happy coding!
 
diff --git a/app/controllers/products_controller.rb b/app/controllers/products_controller.rb
@@ -0,0 +1,58 @@
+class ProductsController < ApplicationController
+  before_action :set_product, only: [:show, :edit, :update, :destroy]
+
+  # GET /products
+  def index
+    @products = Product.all
+  end
+
+  # GET /products/1
+  def show
+  end
+
+  # GET /products/new
+  def new
+    @product = Product.new
+  end
+
+  # GET /products/1/edit
+  def edit
+  end
+
+  # POST /products
+  def create
+    @product = Product.new(product_params)
+
+    if @product.save
+      redirect_to @product, notice: 'Product was successfully created.'
+    else
+      render :new
+    end
+  end
+
+  # PATCH/PUT /products/1
+  def update
+    if @product.update(product_params)
+      redirect_to @product, notice: 'Product was successfully updated.'
+    else
+      render :edit
+    end
+  end
+
+  # DELETE /products/1
+  def destroy
+    @product.destroy
+    redirect_to products_url, notice: 'Product was successfully destroyed.'
+  end
+
+  private
+    # Use callbacks to share common setup or constraints between actions.
+    def set_product
+      @product = Product.find(params[:id])
+    end
+
+    # Only allow a trusted parameter "white list" through.
+    def product_params
+      params.require(:product).permit(:name, :description, :price, :status)
+    end
+end
diff --git a/app/models/product.rb b/app/models/product.rb
@@ -0,0 +1,11 @@
+class Product < ApplicationRecord
+  enum status: {
+    draft: 0,
+    published: 1,
+    cancelled: 2
+  }
+
+  validates :name,
+            :description,
+            :price, presence: true
+end
diff --git a/app/views/products/_form.html.erb b/app/views/products/_form.html.erb
@@ -0,0 +1,32 @@
+<%= form_with(model: product, local: true) do |form| %>
+  <% if product.errors.any? %>
+    <div id="error_explanation">
+      <h2><%= pluralize(product.errors.count, "error") %> prohibited this product from being saved:</h2>
+
+      <ul>
+        <% product.errors.full_messages.each do |message| %>
+          <li><%= message %></li>
+        <% end %>
+      </ul>
+    </div>
+  <% end %>
+
+  <div class="field">
+    <%= form.label :name %>
+    <%= form.text_field :name %>
+  </div>
+
+  <div class="field">
+    <%= form.label :description %>
+    <%= form.text_area :description %>
+  </div>
+
+  <div class="field">
+    <%= form.label :price %>
+    <%= form.text_field :price %>
+  </div>
+
+  <div class="actions">
+    <%= form.submit 'Create' %>
+  </div>
+<% end %>
diff --git a/app/views/products/edit.html.erb b/app/views/products/edit.html.erb
@@ -0,0 +1,6 @@
+<h1>Editing Product</h1>
+
+<%= render 'form', product: @product %>
+
+<%= link_to 'Show', @product %> |
+<%= link_to 'Back', products_path %>
diff --git a/app/views/products/index.html.erb b/app/views/products/index.html.erb
@@ -0,0 +1,31 @@
+<p id="notice"><%= notice %></p>
+
+<h1>Products</h1>
+
+<table>
+  <thead>
+    <tr>
+      <th>Name</th>
+      <th>Description</th>
+      <th>Price</th>
+      <th colspan="3"></th>
+    </tr>
+  </thead>
+
+  <tbody>
+    <% @products.each do |product| %>
+      <tr>
+        <td><%= product.name %></td>
+        <td><%= product.description %></td>
+        <td><%= product.price %></td>
+        <td><%= link_to 'Show', product %></td>
+        <td><%= link_to 'Edit', edit_product_path(product) %></td>
+        <td><%= link_to 'Destroy', product, method: :delete, data: { confirm: 'Are you sure?' } %></td>
+      </tr>
+    <% end %>
+  </tbody>
+</table>
+
+<br>
+
+<%= link_to 'New Product', new_product_path %>
diff --git a/app/views/products/new.html.erb b/app/views/products/new.html.erb
@@ -0,0 +1,5 @@
+<h1>New Product</h1>
+
+<%= render 'form', product: @product %>
+
+<%= link_to 'Back', products_path %>
diff --git a/app/views/products/show.html.erb b/app/views/products/show.html.erb
@@ -0,0 +1,28 @@
+<p id="notice"><%= notice %></p>
+
+<%= form_for @product do |f| %>
+  <%= f.hidden_field :status, value: :published %>
+  <%= f.submit 'Publish' %>
+<% end %>
+
+<p class='product_title'>
+  <%= @product.status.capitalize %> - <%= @product.name %>
+</p>
+
+<p>
+  <strong>Name:</strong>
+  <%= @product.name %>
+</p>
+
+<p>
+  <strong>Description:</strong>
+  <%= @product.description %>
+</p>
+
+<p>
+  <strong>Price:</strong>
+  <%= @product.price %>
+</p>
+
+<%= link_to 'Edit', edit_product_path(@product) %> |
+<%= link_to 'Back', products_path %>
diff --git a/config/routes.rb b/config/routes.rb
@@ -1,4 +1,5 @@
 Rails.application.routes.draw do
+  resources :products
   devise_for :users
   root to: "landing#index"
   # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html
diff --git a/db/migrate/20200227193253_create_products.rb b/db/migrate/20200227193253_create_products.rb
@@ -2,8 +2,8 @@ class CreateProducts < ActiveRecord::Migration[6.0]
   def change
     create_table :products do |t|
       t.string :name
-      t.float :price
       t.text :description
+      t.float :price
 
       t.timestamps
     end
diff --git a/db/migrate/20200227193902_add_status_to_products.rb b/db/migrate/20200227193902_add_status_to_products.rb
@@ -0,0 +1,5 @@
+class AddStatusToProducts < ActiveRecord::Migration[6.0]
+  def change
+    add_column :products, :status, :integer, default: 0
+  end
+end
diff --git a/db/schema.rb b/db/schema.rb
@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2020_02_26_030834) do
+ActiveRecord::Schema.define(version: 2020_02_27_193902) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -23,10 +23,11 @@
 
   create_table "products", force: :cascade do |t|
     t.string "name"
-    t.float "price"
     t.text "description"
+    t.float "price"
     t.datetime "created_at", precision: 6, null: false
     t.datetime "updated_at", precision: 6, null: false
+    t.integer "status", default: 0
   end
 
   create_table "users", force: :cascade do |t|
diff --git a/erd.pdf b/erd.pdf
diff --git a/spec/factories/products.rb b/spec/factories/products.rb
@@ -1,7 +1,7 @@
 FactoryBot.define do
   factory :product do
     name { FFaker::Product.product_name }
-    price { 10.00 }
-    description { "A sample description" }
+    description { FFaker::Product.letters(200) }
+    price { 100.0 }
   end
 end
diff --git a/spec/models/product_spec.rb b/spec/models/product_spec.rb
@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe Product, type: :model do
+  pending "add some examples to (or delete) #{__FILE__}"
+end
diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb
@@ -1,11 +1,15 @@
+# frozen_string_literal: true
+
 # This file is copied to spec/ when you run 'rails generate rspec:install'
 require 'spec_helper'
 ENV['RAILS_ENV'] ||= 'test'
 
 require File.expand_path('../config/environment', __dir__)
 
 # Prevent database truncation if the environment is production
-abort("The Rails environment is running in production mode!") if Rails.env.production?
+if Rails.env.production?
+  abort('The Rails environment is running in production mode!')
+end
 require 'rspec/rails'
 # require 'simplecov_helper'
 # Add additional requires below this line. Rails is not loaded until this point!
@@ -23,7 +27,7 @@
 # directory. Alternatively, in the individual `*_spec.rb` files, manually
 # require only the support files necessary.
 #
-Dir[Rails.root.join('spec/support/**/*.rb')].each { |f| require f }
+Dir[Rails.root.join('spec/support/**/*.rb')].sort.each { |f| require f }
 
 # Checks for pending migrations and applies them before tests are run.
 # If you are not using ActiveRecord, you can remove these lines.
diff --git a/spec/support/page/product.rb b/spec/support/page/product.rb
@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module Page
+  class Product
+    include Rails.application.routes.url_helpers
+    include Capybara::DSL
+
+    def initialize(name)
+      @name = name
+    end
+
+    def create
+      visit new_product_path
+      fill_in :product_name, with: @name
+      fill_in :product_description, with: 'description'
+      fill_in :product_price, with: 500
+      click_button 'Create'
+    end
+
+    def exists?
+      product_title.has_text? "Draft - #{@name}"
+    end
+
+    def publish
+      click_button 'Publish'
+    end
+
+    def published?
+      product_title.has_text? "Published - #{@name}"
+    end
+
+    private
+
+    def product_title
+      find('p.product_title')
+    end
+  end
+end
diff --git a/spec/system/product_spec.rb b/spec/system/product_spec.rb
@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'Product', type: :system do
+  context 'Product creation' do
+    it 'creates the product' do
+      product_name = 'Xbox One'
+      page_product = Page::Product.new(product_name)
+      page_product.create
+
+      expect(page_product).to exist
+    end
+  end
+
+  context 'Product publication' do
+    it 'publishes the product' do
+      product_name = 'Nintendo Switch'
+      page_product = Page::Product.new(product_name)
+      page_product.create
+
+      page_product.publish
+
+      expect(page_product).to be_published
+    end
+  end
+end

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`Rails.application.routes.draw do`
	`2`	`+ resources :products`
`2`	`3`	`devise_for :users`
`3`	`4`	`root to: "landing#index"`
`4`	`5`	`# For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html`