Skip to content

Commit ba3efcc

Browse files
Wip: todos and bugs to fix
1 parent 520835f commit ba3efcc

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

asset/js/widget/ActionList.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ define(["../notjQuery"], function ($) {
9090
onClick(event) {
9191
let target = event.currentTarget;
9292

93-
if (target.matches('a') && (! target.matches('.subject') || event.ctrlKey || event.metaKey)) {
93+
if (target.matches('a') && (! target.matches('.subject') || event.ctrlKey || event.metaKey)) { //TODO: don't use icinga specific classes
9494
return true;
9595
}
9696

@@ -169,6 +169,7 @@ define(["../notjQuery"], function ($) {
169169
if (! this.isMultiSelectable || ! this.isPrimary) {
170170
return;
171171
}
172+
//TODO: remove icinga specific classes, make this function more generic
172173

173174
let activeItemCount = this.getActiveItems().length;
174175
let footer = this.list.closest('.container').querySelector('.footer');
@@ -405,6 +406,7 @@ define(["../notjQuery"], function ($) {
405406
* @param pressedKey Pressed key (`ArrowUp` or `ArrowDown`)
406407
*/
407408
scrollItemIntoView(item, pressedKey) {
409+
//TODO: is not working(never did) in Host/Service groups
408410
item.scrollIntoView({block: "nearest"});
409411
let directionalNext = this.getDirectionalNext(item, pressedKey);
410412

@@ -501,6 +503,8 @@ define(["../notjQuery"], function ($) {
501503
* @param detailUrl
502504
*/
503505
load(detailUrl = null) {
506+
//TODO: somehow item is deselected when req is canceled and new req is started
507+
//isProcessing is not working as expected
504508
if (! detailUrl) {
505509
let activeItems = this.getActiveItems();
506510
if (activeItems.length) {

0 commit comments

Comments
 (0)