Develop #196
Develop #196
Conversation
…ed Quickstart Guide link to direct to the new URL, added Vertex AI to supported backends, and revised section titles for consistency. Enhanced deployment options with specific self-hosted links for GCP, AWS, and Azure.
…r enhanced visibility and engagement metrics.
… revise project description for clarity and engagement.
…nd Quickstart guide for better user engagement. Improved formatting in index.md and added spacing for clarity.
… improved user experience and engagement.
…UP.md, MVP_RELEASE_CHECKLIST.md, QUICK_RELEASE.md, RELEASE_GUIDE.md, and release-related scripts. Also, delete unused images and test files to streamline the project structure.
Sync develop with latest main changes and resolve roadmap documentation conflicts.
- Changed the roadmap link in mkdocs.yml to point to the correct file. - Updated index.md to include absolute URLs for Quickstart, Architecture overview, and Roadmap links. - Removed outdated ADK and LangGraph agent framework documentation files. - Fixed links in the Quickstart guide to reflect the new paths for agent frameworks.
- Updated mkdocs.yml to simplify navigation by renaming the SSO/RBAC section to SSO. - Removed several outdated documentation files including changelog.md, contributing.md, faq.md, known-bugs.md, support.md, api.md, cli.md, configuration.md, environment.md, and rest-api.md to streamline the documentation. - Retained the roadmap link in mkdocs.yml for continued access to relevant information.
- Changed Quickstart, Architecture overview, and Roadmap links to point to their respective directories for improved navigation.
- Corrected URLs for Quickstart, Architecture overview, and Roadmap to ensure they point to the appropriate sections, enhancing user experience.
- Adjusted the formatting of the "Next" section links in the Quickstart guide for better readability and consistency.
…gGraph" for improved accuracy.
…ove user experience.
- Updated mkdocs.yml to include new redirect mappings for canonical URLs, improving navigation and accessibility. - Revised README.md to clarify the platform's purpose and capabilities, including updated links and formatting for better user engagement. - Removed outdated index.html and agent framework documentation files to streamline the project structure. - Improved index.md with new sections for quick access to guides and resources, enhancing user experience. - Adjusted various documentation files for consistency in language and formatting, ensuring clarity across the platform's documentation.
feat: update docs
Updated Discord link in README.md
* Update README and index.md for improved clarity and navigation. Changed Quickstart Guide link to direct to the new URL, added Vertex AI to supported backends, and revised section titles for consistency. Enhanced deployment options with specific self-hosted links for GCP, AWS, and Azure. * Update README to include GitHub Stars badge and Star History chart for enhanced visibility and engagement metrics. * Update README to reflect Python version change from 3.13+ to 3.12 and revise project description for clarity and engagement. * Enhance documentation by adding a YouTube video embed to the README and Quickstart guide for better user engagement. Improved formatting in index.md and added spacing for clarity. * Replace YouTube video embed with a clickable image link in README for improved user experience and engagement. * screen yt * Enhance doc * Remove outdated documentation files including DEBUG_GUIDE.md, DEV_SETUP.md, MVP_RELEASE_CHECKLIST.md, QUICK_RELEASE.md, RELEASE_GUIDE.md, and release-related scripts. Also, delete unused images and test files to streamline the project structure. * Enhance docs + add lancgain tools (#187) * Update documentation links and remove outdated agent framework guides - Changed the roadmap link in mkdocs.yml to point to the correct file. - Updated index.md to include absolute URLs for Quickstart, Architecture overview, and Roadmap links. - Removed outdated ADK and LangGraph agent framework documentation files. - Fixed links in the Quickstart guide to reflect the new paths for agent frameworks. * Refactor documentation structure and remove outdated files - Updated mkdocs.yml to simplify navigation by renaming the SSO/RBAC section to SSO. - Removed several outdated documentation files including changelog.md, contributing.md, faq.md, known-bugs.md, support.md, api.md, cli.md, configuration.md, environment.md, and rest-api.md to streamline the documentation. - Retained the roadmap link in mkdocs.yml for continued access to relevant information. * Update documentation links in index.md for consistency and accuracy - Changed Quickstart, Architecture overview, and Roadmap links to point to their respective directories for improved navigation. * Update documentation links in index.md for improved navigation - Corrected URLs for Quickstart, Architecture overview, and Roadmap to ensure they point to the appropriate sections, enhancing user experience. * Update Quickstart documentation for improved link formatting - Adjusted the formatting of the "Next" section links in the Quickstart guide for better readability and consistency. * Fix typo in Quickstart documentation by correcting "LanGraph" to "LangGraph" for improved accuracy. * Remove outdated links from index.md to streamline navigation and improve user experience. * Enhance documentation and configuration for Idun Agent Platform - Updated mkdocs.yml to include new redirect mappings for canonical URLs, improving navigation and accessibility. - Revised README.md to clarify the platform's purpose and capabilities, including updated links and formatting for better user engagement. - Removed outdated index.html and agent framework documentation files to streamline the project structure. - Improved index.md with new sections for quick access to guides and resources, enhancing user experience. - Adjusted various documentation files for consistency in language and formatting, ensuring clarity across the platform's documentation.
Updated Discord link in README.md
* Update Discord links across documentation Replaced outdated Discord server links with the new invite link in README.md, index.md, and various documentation files to ensure users have access to the correct community support channel. * Update Discord link in README.md to the new invite URL for community access
* plan preparation * add: telemetry first commit * Enhance telemetry functionality and documentation - Added telemetry configuration sanitization to ensure sensitive data is redacted before transmission. - Updated lifespan management to handle telemetry initialization errors gracefully. - Included a new section in README.md to inform users about telemetry data collection and how to disable it. - Added 'pyyaml' as a dependency in the project. * Remove engine telemetry plan file - Deleted the engine telemetry plan markdown file as it is no longer needed for the project. - This change helps streamline the project structure by removing outdated documentation. * Update license link in README.md to point to the correct MIT license URL
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 25048295 | Triggered | Generic High Entropy Secret | 889fd5a | libs/idun_agent_engine/src/idun_agent_engine/telemetry/telemetry.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
- Replaced the MIT license with the GNU General Public License v3 (GPLv3) in LICENSE, pyproject.toml files for the main project and its libraries. - Updated README.md to reflect the new GPL-3.0-only license badge. - Ensured all relevant files and dependencies are aligned with the new licensing terms.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| global _telemetry_singleton | ||
| if _telemetry_singleton is None: | ||
| _telemetry_singleton = IdunTelemetry() | ||
| return _telemetry_singleton |
There was a problem hiding this comment.
Thread-unsafe singleton initialization may cause resource leak
Low Severity
The get_telemetry() singleton function and _ensure_executor() method lack thread synchronization. If called concurrently before initialization completes, multiple IdunTelemetry instances or ThreadPoolExecutor objects could be created. Orphaned instances would never be shutdown, causing their executor threads to leak. While unlikely in practice since lifespan startup is single-threaded, the code uses locking for _get_client() but inconsistently omits it for other lazy-initialized fields.
Additional Locations (1)
* feat: add tui * feat: add mcp + adk + fixed background process keeps working when server shutdown * refactor: update dependencies and improve package structure - Removed the idun-platform-cli dependency from pyproject.toml. - Updated the textual dependency version in idun_agent_engine's pyproject.toml. - Enhanced the package structure in idun_agent_engine by specifying sources for wheel builds. - Added versioning information to the main application display in the CLI. --------- Co-authored-by: AhmedEnnaifer <ahmedennaifer00@gmail.com>
…gurations - Updated Docker images for manager and web services in docker-compose.yml. - Incremented version numbers in pyproject.toml and _version.py for idun-agent-engine and idun-agent-schema. - Updated version in Dockerfile and pyproject.toml for idun-agent-manager. - Adjusted __version__ in __init__.py files for idun-agent-engine and idun-agent-manager.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| sys.exit(0) | ||
| except Exception as e: | ||
| print(f"[ERROR]: Failed to launch the Idun TUI: {e}") | ||
| sys.exit(1) |
There was a problem hiding this comment.
CLI command always exits with error code
High Severity
The sys.exit(1) on line 23 is outside the except Exception block due to incorrect indentation. After a successful app.run() completes normally, execution falls through to this line and exits with error code 1. This causes the idun init command to always report failure even when the TUI runs successfully.
| self.run_worker(self._stream_logs(process), exclusive=True) | ||
|
|
||
| except Exception as e: | ||
| self.notify(f"Failed to start server: {e}", severity="error") |
There was a problem hiding this comment.
Subprocess orphaned when fcntl fails after Popen succeeds
Medium Severity
When subprocess.Popen succeeds but subsequent fcntl calls fail (e.g., on Windows where fcntl doesn't exist), the subprocess continues running but self.server_process is never set. The exception handler only shows a notification without terminating the orphaned process. The user sees an error but the server is actually running in the background with no way to stop it from the TUI.
| self.notify( | ||
| "Debug: Config is empty, agent_path might not be set", | ||
| severity="warning", | ||
| ) |
There was a problem hiding this comment.
Debug message displayed to end users
Low Severity
A notification message starting with "Debug: Config is empty, agent_path might not be set" is shown to users when navigating to the serve section without a valid config. The "Debug:" prefix and reference to internal variables like agent_path indicate this was intended for development debugging and not meant to be user-facing.
Note
Licensing & versioning
COPYING, replacesLICENSE, updates badges/classifiers) and bumps version to0.4.0Telemetry
IDUN_TELEMETRY_ENABLEDand startup/shutdown events; sanitizes config prior to captureCLI/TUI
idun initTextual TUI for creating/validating agent configs and running a local server; adds validation utilities and config managerDocs & UX
overview,docker-mcp,mcp-server), expands guardrails guide, and updates links across docsRuntime & images
freezaa9/idun-ai{,-web}:0.4.0GuardrailsHubGuard) and wiring for telemetry in server lifespanWritten by Cursor Bugbot for commit 0d97920. This will update automatically on new commits. Configure here.