From 7923d7d9043043c56ef7396bfabe36f49675ba2d Mon Sep 17 00:00:00 2001 From: Damyan Petev Date: Thu, 27 Feb 2025 16:39:39 +0200 Subject: [PATCH 1/2] test(*): apply control flow suggestions --- .../grid-editing-actions.component.spec.ts | 10 +++++----- .../grid-pinning-actions.component.spec.ts | 4 ++-- .../src/lib/buttonGroup/buttongroup.component.spec.ts | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-editing-actions.component.spec.ts b/projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-editing-actions.component.spec.ts index 1abfd40b3b6..9c9841e8655 100644 --- a/projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-editing-actions.component.spec.ts +++ b/projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-editing-actions.component.spec.ts @@ -390,7 +390,7 @@ describe('igxGridEditingActions #grid ', () => { template: ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { @@ -469,7 +469,7 @@ class IgxActionStripTestingComponent implements OnInit { template: ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { @@ -491,7 +491,7 @@ class IgxActionStripPinEditComponent extends IgxActionStripTestingComponent { template: ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { @@ -512,7 +512,7 @@ class IgxActionStripEditMenuComponent extends IgxActionStripTestingComponent { template: ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { @@ -534,7 +534,7 @@ class IgxActionStripOneRowComponent extends IgxActionStripTestingComponent { template: ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { diff --git a/projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-pinning-actions.component.spec.ts b/projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-pinning-actions.component.spec.ts index 2d9efab5b96..abc864009c7 100644 --- a/projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-pinning-actions.component.spec.ts +++ b/projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-pinning-actions.component.spec.ts @@ -102,7 +102,7 @@ describe('igxGridPinningActions #grid ', () => { template: ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { @@ -176,7 +176,7 @@ class IgxActionStripTestingComponent implements OnInit { template: ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { diff --git a/projects/igniteui-angular/src/lib/buttonGroup/buttongroup.component.spec.ts b/projects/igniteui-angular/src/lib/buttonGroup/buttongroup.component.spec.ts index e73de82221c..c76b35c653f 100644 --- a/projects/igniteui-angular/src/lib/buttonGroup/buttongroup.component.spec.ts +++ b/projects/igniteui-angular/src/lib/buttonGroup/buttongroup.component.spec.ts @@ -584,7 +584,7 @@ class ButtonGroupWithSelectedButtonComponent { @Component({ template: ` - @for (item of items; track item) { + @for (item of items; track item.key) { } From 847f86528adaf7fe102e9343e12f359cf1c00eb9 Mon Sep 17 00:00:00 2001 From: Damyan Petev Date: Thu, 27 Feb 2025 18:32:29 +0200 Subject: [PATCH 2/2] test(*): more control flow for track adjustments --- .../src/lib/chips/chip.spec.ts | 4 ++-- .../src/lib/chips/chips-area.spec.ts | 4 ++-- .../filter/filter.directive.spec.ts | 2 +- .../lib/drop-down/drop-down.component.spec.ts | 14 +++++------ .../src/lib/grids/grid/cell.spec.ts | 2 +- .../grids/grid/grid-mrl-keyboard-nav.spec.ts | 6 ++--- .../lib/grids/grid/grid-row-pinning.spec.ts | 4 ++-- .../src/lib/grids/grid/grid.component.spec.ts | 20 ++++++++-------- .../src/lib/grids/grid/grid.groupby.spec.ts | 2 +- .../lib/grids/grid/grid.master-detail.spec.ts | 4 ++-- .../grid.multi-row-layout.integration.spec.ts | 14 +++++------ .../grids/grid/grid.multi-row-layout.spec.ts | 4 ++-- .../src/lib/grids/state.directive.spec.ts | 2 +- .../lib/grids/state.hierarchicalgrid.spec.ts | 4 ++-- .../src/lib/grids/state.treegrid.spec.ts | 2 +- .../src/lib/radio/radio.component.spec.ts | 2 +- .../src/lib/select/select.component.spec.ts | 4 ++-- .../lib/test-utils/grid-mch-sample.spec.ts | 4 ++-- .../src/lib/test-utils/grid-samples.spec.ts | 16 ++++++------- .../grid-validation-samples.spec.ts | 8 +++---- .../lib/test-utils/template-strings.spec.ts | 12 +++++----- .../src/lib/tree/tree-samples.spec.ts | 24 +++++++++---------- .../src/lib/tree/tree.spec.ts | 6 ++--- 23 files changed, 82 insertions(+), 82 deletions(-) diff --git a/projects/igniteui-angular/src/lib/chips/chip.spec.ts b/projects/igniteui-angular/src/lib/chips/chip.spec.ts index e518735693d..d60e87f74da 100644 --- a/projects/igniteui-angular/src/lib/chips/chip.spec.ts +++ b/projects/igniteui-angular/src/lib/chips/chip.spec.ts @@ -15,7 +15,7 @@ import { getComponentSize } from '../core/utils'; @Component({ template: ` - @for (chip of chipList; track chip) { + @for (chip of chipList; track chip.id) { - @for (chip of chipList; track chip) { + @for (chip of chipList; track chip.id) { label suf diff --git a/projects/igniteui-angular/src/lib/chips/chips-area.spec.ts b/projects/igniteui-angular/src/lib/chips/chips-area.spec.ts index 54e5916d107..66ce7cb05a1 100644 --- a/projects/igniteui-angular/src/lib/chips/chips-area.spec.ts +++ b/projects/igniteui-angular/src/lib/chips/chips-area.spec.ts @@ -11,7 +11,7 @@ import { IgxPrefixDirective } from './public_api'; @Component({ template: ` - @for (chip of chipList; track chip) { + @for (chip of chipList; track chip.id) { drag_indicator @@ -59,7 +59,7 @@ class TestChipSelectComponent extends TestChipComponent { @Component({ template: ` - @for (chip of chipList; track chip) { + @for (chip of chipList; track chip.id) { drag_indicator diff --git a/projects/igniteui-angular/src/lib/directives/filter/filter.directive.spec.ts b/projects/igniteui-angular/src/lib/directives/filter/filter.directive.spec.ts index 49ddf007b6f..dd91e2c86da 100644 --- a/projects/igniteui-angular/src/lib/directives/filter/filter.directive.spec.ts +++ b/projects/igniteui-angular/src/lib/directives/filter/filter.directive.spec.ts @@ -213,7 +213,7 @@ class DeclarativeListTestComponent { @Component({ template: ` - @for (item of dataSourceItems | igxFilter: fo; track item) { + @for (item of dataSourceItems | igxFilter: fo; track item.key) { {{item.text}} } `, diff --git a/projects/igniteui-angular/src/lib/drop-down/drop-down.component.spec.ts b/projects/igniteui-angular/src/lib/drop-down/drop-down.component.spec.ts index 6ce79bc3fc3..124f9f7229b 100644 --- a/projects/igniteui-angular/src/lib/drop-down/drop-down.component.spec.ts +++ b/projects/igniteui-angular/src/lib/drop-down/drop-down.component.spec.ts @@ -1298,7 +1298,7 @@ describe('IgxDropDown ', () => { - @for (item of items; track item) { + @for (item of items; track item.field) { {{item.field}} @@ -1338,14 +1338,14 @@ class IgxDropDownTestComponent { template: ` - @for (item of items; track item) { + @for (item of items; track item.field) { {{ item.field }} } - @for (item of items; track item) { + @for (item of items; track item.field) { {{ item.field }} @@ -1403,7 +1403,7 @@ class DoubleIgxDropDownComponent implements OnInit { - @for (item of items; track item) { + @for (item of items; track item.field) { {{ item.field }} @@ -1441,7 +1441,7 @@ class IgxDropDownAnchorTestComponent { @Component({ template: ` - @for (item of items; track item) { + @for (item of items; track item.field) { {{ item.field }} @@ -1466,9 +1466,9 @@ class InputWithDropDownDirectiveComponent { @Component({ template: ` - @for (parent of data; track parent) { + @for (parent of data; track parent.name) { - @for (child of parent.children; track child) { + @for (child of parent.children; track child.value) { {{ child.name }} diff --git a/projects/igniteui-angular/src/lib/grids/grid/cell.spec.ts b/projects/igniteui-angular/src/lib/grids/grid/cell.spec.ts index 47aa02b7bd0..15965570927 100644 --- a/projects/igniteui-angular/src/lib/grids/grid/cell.spec.ts +++ b/projects/igniteui-angular/src/lib/grids/grid/cell.spec.ts @@ -405,7 +405,7 @@ describe('IgxGrid - Cell component #grid', () => { @Component({ template: ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { { @Component({ template: ` - @for (group of colGroups; track group) { + @for (group of colGroups; track group.group) { - @for (col of group.columns; track col) { + @for (col of group.columns; track col.field) { diff --git a/projects/igniteui-angular/src/lib/grids/grid/grid-row-pinning.spec.ts b/projects/igniteui-angular/src/lib/grids/grid/grid-row-pinning.spec.ts index bb08b5b7e06..cc60ea60646 100644 --- a/projects/igniteui-angular/src/lib/grids/grid/grid-row-pinning.spec.ts +++ b/projects/igniteui-angular/src/lib/grids/grid/grid-row-pinning.spec.ts @@ -1436,9 +1436,9 @@ export class GridRowPinningComponent { template: ` - @for (group of colGroups; track group) { + @for (group of colGroups; track group.group) { - @for (col of group.columns; track col) { + @for (col of group.columns; track col.field) { diff --git a/projects/igniteui-angular/src/lib/grids/grid/grid.component.spec.ts b/projects/igniteui-angular/src/lib/grids/grid/grid.component.spec.ts index 51ac5b0b53f..f30a4770c43 100644 --- a/projects/igniteui-angular/src/lib/grids/grid/grid.component.spec.ts +++ b/projects/igniteui-angular/src/lib/grids/grid/grid.component.spec.ts @@ -2928,7 +2928,7 @@ describe('IgxGrid Component Tests #grid', () => { @Component({ template: `
- @for (column of columns; track column) { + @for (column of columns; track column.field) { @@ -3004,7 +3004,7 @@ export class IgxGridTestComponent { @Component({ template: ` - @for (col of columns; track col) { + @for (col of columns; track col.key) { } @@ -3132,7 +3132,7 @@ export class IgxGridColumnHeaderInGroupAutoSizeComponent { @Component({ template: ` - @for (col of columns; track col) { + @for (col of columns; track col.key) { } @@ -3149,7 +3149,7 @@ export class IgxGridColumnPercentageWidthComponent extends IgxGridDefaultRenderi @Component({ template: ` - @for (col of columns; track col) { + @for (col of columns; track col.key) { } @@ -3430,7 +3430,7 @@ export class IgxGridFormattingComponent extends BasicGridComponent { - @for (column of columns; track column) { + @for (column of columns; track column.field) { - @for (column of columns; track column) { + @for (column of columns; track column.field) { - @for (column of columns; track column) { + @for (column of columns; track column.field) { - @for (column of columns; track column) { + @for (column of columns; track column.field) {
- @for (column of columns; track column) { + @for (column of columns; track column.field) { - @for (column of columns; track column) { + @for (column of columns; track column.field) { } `, diff --git a/projects/igniteui-angular/src/lib/grids/grid/grid.groupby.spec.ts b/projects/igniteui-angular/src/lib/grids/grid/grid.groupby.spec.ts index 4eb5a737125..4d797afa3ce 100644 --- a/projects/igniteui-angular/src/lib/grids/grid/grid.groupby.spec.ts +++ b/projects/igniteui-angular/src/lib/grids/grid/grid.groupby.spec.ts @@ -4123,7 +4123,7 @@ export class CustomTemplateGridComponent extends DataParent { [width]='width' [height]='height' [data]="testData"> - @for (c of columns; track c) { + @for (c of columns; track c.field) { } diff --git a/projects/igniteui-angular/src/lib/grids/grid/grid.master-detail.spec.ts b/projects/igniteui-angular/src/lib/grids/grid/grid.master-detail.spec.ts index 971bfea8388..718ac435400 100644 --- a/projects/igniteui-angular/src/lib/grids/grid/grid.master-detail.spec.ts +++ b/projects/igniteui-angular/src/lib/grids/grid/grid.master-detail.spec.ts @@ -1257,7 +1257,7 @@ describe('IgxGrid Master Detail #grid', () => { @Component({ template: ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { } @@ -1309,7 +1309,7 @@ export class DefaultGridMasterDetailComponent { template: ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { } diff --git a/projects/igniteui-angular/src/lib/grids/grid/grid.multi-row-layout.integration.spec.ts b/projects/igniteui-angular/src/lib/grids/grid/grid.multi-row-layout.integration.spec.ts index ee4f9232287..afc2c53e034 100644 --- a/projects/igniteui-angular/src/lib/grids/grid/grid.multi-row-layout.integration.spec.ts +++ b/projects/igniteui-angular/src/lib/grids/grid/grid.multi-row-layout.integration.spec.ts @@ -1232,9 +1232,9 @@ describe('IgxGrid - multi-row-layout Integration #grid - ', () => { } - @for (group of colGroups; track group) { + @for (group of colGroups; track group.group) { - @for (col of group.columns; track col) { + @for (col of group.columns; track col.field) { @@ -1333,9 +1333,9 @@ export class ColumnLayoutPinningTestComponent { @Component({ template: ` - @for (group of colGroups; track group) { + @for (group of colGroups; track group.group) { - @for (col of group.columns; track col) { + @for (col of group.columns; track col.field) { @@ -1352,9 +1352,9 @@ export class ColumnLayoutFilteringTestComponent extends ColumnLayoutPinningTestC @Component({ template: ` - @for (group of colGroups; track group) { + @for (group of colGroups; track group.group) { - @for (col of group.columns; track col) { + @for (col of group.columns; track col.field) { @@ -1398,7 +1398,7 @@ export class ColumnLayoutGroupingTestComponent extends ColumnLayoutPinningTestCo @for (group of colGroups; track group.group) { - @for (col of group.columns; track col) { + @for (col of group.columns; track col.field) { diff --git a/projects/igniteui-angular/src/lib/grids/grid/grid.multi-row-layout.spec.ts b/projects/igniteui-angular/src/lib/grids/grid/grid.multi-row-layout.spec.ts index 2b5ffd40f0b..e9e11260b97 100644 --- a/projects/igniteui-angular/src/lib/grids/grid/grid.multi-row-layout.spec.ts +++ b/projects/igniteui-angular/src/lib/grids/grid/grid.multi-row-layout.spec.ts @@ -1185,9 +1185,9 @@ export class ColumnLayoutTestComponent { - @for (group of colGroups; track group) { + @for (group of colGroups; track group.group) { - @for (col of group.columns; track col) { + @for (col of group.columns; track col.field) { diff --git a/projects/igniteui-angular/src/lib/grids/state.directive.spec.ts b/projects/igniteui-angular/src/lib/grids/state.directive.spec.ts index 2084025bb84..e40a9410bd8 100644 --- a/projects/igniteui-angular/src/lib/grids/state.directive.spec.ts +++ b/projects/igniteui-angular/src/lib/grids/state.directive.spec.ts @@ -879,7 +879,7 @@ class HelperFunctions { template: ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { - @for (c of columns; track c) { + @for (c of columns; track c.field) { - @for (c of childColumns; track c) { + @for (c of childColumns; track c.field) { - @for (c of columns; track c) { + @for (c of columns; track c.field) { - @for (location of locations; track location) { + @for (location of locations; track location.continent) { {{location.continent}} @for (capital of location.capitals; track capital) { @@ -3100,7 +3100,7 @@ class IgxSelectHeaderFooterComponent implements OnInit {
- @for (column of columns; track column) { + @for (column of columns; track column.field) { {{column.field}} diff --git a/projects/igniteui-angular/src/lib/test-utils/grid-mch-sample.spec.ts b/projects/igniteui-angular/src/lib/test-utils/grid-mch-sample.spec.ts index 436f9facf46..cff8bdee686 100644 --- a/projects/igniteui-angular/src/lib/test-utils/grid-mch-sample.spec.ts +++ b/projects/igniteui-angular/src/lib/test-utils/grid-mch-sample.spec.ts @@ -282,9 +282,9 @@ export class NestedColGroupsGridComponent { @Component({ template: ` - @for (colGroup of columnGroups; track colGroup) { + @for (colGroup of columnGroups; track colGroup.columnHeader) { - @for (column of colGroup.columns; track column) { + @for (column of colGroup.columns; track column.field) { } diff --git a/projects/igniteui-angular/src/lib/test-utils/grid-samples.spec.ts b/projects/igniteui-angular/src/lib/test-utils/grid-samples.spec.ts index 2db27c040dc..9d1587f38aa 100644 --- a/projects/igniteui-angular/src/lib/test-utils/grid-samples.spec.ts +++ b/projects/igniteui-angular/src/lib/test-utils/grid-samples.spec.ts @@ -54,7 +54,7 @@ export class ColumnHiddenFromMarkupComponent extends BasicGridComponent { @Component({ template: ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { - @for (group of colGroups; track group) { + @for (group of colGroups; track group.field) { - @for (col of group.columns; track col) { + @for (col of group.columns; track col.field) { @@ -1935,9 +1935,9 @@ export class CollapsibleGroupsTemplatesTestComponent { @Component({ template: ` - @for (colGroup of columnGroups; track colGroup) { + @for (colGroup of columnGroups; track colGroup.columnHeader) { - @for (column of colGroup.columns; track column) { + @for (column of colGroup.columns; track column.field) { } @@ -2208,9 +2208,9 @@ export class IgxGridFormattedValuesSortingComponent extends BasicGridComponent { @Component({ template: ` - @for (group of colGroups; track group) { + @for (group of colGroups; track group.group) { - @for (col of group.columns; track col) { + @for (col of group.columns; track col.field) { @@ -2258,7 +2258,7 @@ export class MRLTestComponent { template: ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { diff --git a/projects/igniteui-angular/src/lib/test-utils/grid-validation-samples.spec.ts b/projects/igniteui-angular/src/lib/test-utils/grid-validation-samples.spec.ts index 79e237fa57e..607313de0e5 100644 --- a/projects/igniteui-angular/src/lib/test-utils/grid-validation-samples.spec.ts +++ b/projects/igniteui-angular/src/lib/test-utils/grid-validation-samples.spec.ts @@ -36,7 +36,7 @@ export class ForbiddenValidatorDirective extends Validators { template: ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { @@ -64,7 +64,7 @@ export class IgxGridValidationTestBaseComponent { template: ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { @@ -90,7 +90,7 @@ export class IgxGridValidationTestCustomErrorComponent extends IgxGridValidation template: ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { @@ -118,7 +118,7 @@ export class IgxGridCustomEditorsComponent extends IgxGridValidationTestCustomEr template: ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { diff --git a/projects/igniteui-angular/src/lib/test-utils/template-strings.spec.ts b/projects/igniteui-angular/src/lib/test-utils/template-strings.spec.ts index f865ff7059d..587f1f2b9bd 100644 --- a/projects/igniteui-angular/src/lib/test-utils/template-strings.spec.ts +++ b/projects/igniteui-angular/src/lib/test-utils/template-strings.spec.ts @@ -182,7 +182,7 @@ export class ColumnDefinitions { `; public static resizableColsComponent = ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { }`; public static generatedWithDataType = ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { }`; public static generatedGroupableWithEnabledSummariesAndDataType = ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { }`; public static generatedWithColumnBasedSummariesAndDataType = ` - @for (c of columns; track c) { + @for (c of columns; track c.field) { }`; public static generatedEditable = ` - @for (col of columns; track c) { + @for (col of columns; track col.key) { - @for (node of data; track node) { + @for (node of data; track node.ID) { {{ node.CompanyName }} - @for (child of node.ChildCompanies; track child) { + @for (child of node.ChildCompanies; track child.ID) { {{ child.CompanyName }} - @for (leafchild of child.ChildCompanies; track leafchild) { + @for (leafchild of child.ChildCompanies; track leafchild.ID) { {{ leafchild.CompanyName }} @@ -34,13 +34,13 @@ export class IgxTreeSimpleComponent { @Component({ template: ` - @for (node of data; track node) { + @for (node of data; track node.ID) { {{ node.CompanyName }} - @for (child of node.ChildCompanies; track child) { + @for (child of node.ChildCompanies; track child.ID) { {{ child.CompanyName }} - @for (leafchild of child.ChildCompanies; track leafchild) { + @for (leafchild of child.ChildCompanies; track leafchild.ID) { {{ leafchild.CompanyName }} @@ -73,14 +73,14 @@ export class IgxTreeSelectionSampleComponent { @Component({ template: ` - @for (node of data; track node) { + @for (node of data; track node.ID) { {{ node.CompanyName }} Disable Node Level 1 - @for (child of node.ChildCompanies; track child) { + @for (child of node.ChildCompanies; track child.ID) { {{ child.CompanyName }} - @for (leafchild of child.ChildCompanies; track leafchild) { + @for (leafchild of child.ChildCompanies; track leafchild.ID) { {{ leafchild.CompanyName }} @@ -133,13 +133,13 @@ export class IgxTreeNavigationComponent { @Component({ template: ` - @for (node of data; track node) { + @for (node of data; track node.ID) { {{ node.CompanyName }} - @for (child of node.ChildCompanies; track child) { + @for (child of node.ChildCompanies; track child.ID) { {{ child.CompanyName }} - @for (leafchild of child.ChildCompanies; track leafchild) { + @for (leafchild of child.ChildCompanies; track leafchild.ID) { {{ leafchild.CompanyName }} diff --git a/projects/igniteui-angular/src/lib/tree/tree.spec.ts b/projects/igniteui-angular/src/lib/tree/tree.spec.ts index 03b21aec9db..2fbd662cb60 100644 --- a/projects/igniteui-angular/src/lib/tree/tree.spec.ts +++ b/projects/igniteui-angular/src/lib/tree/tree.spec.ts @@ -680,13 +680,13 @@ describe('IgxTree #treeView', () => { @Component({ template: ` - @for (node of data; track node) { + @for (node of data; track node.id) { {{ node.label }} - @for (child of node.children; track child) { + @for (child of node.children; track child.id) { {{ child.label }} - @for (leafChild of child.children; track leafChild) { + @for (leafChild of child.children; track leafChild.id) { {{ leafChild.label }}