Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Incorrect aria-label implementation on igc-slider component #1410

Open
georgianastasov opened this issue Sep 30, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working slider

Comments

@georgianastasov
Copy link

Which component(s) are affected?

Slider (single/range)

Description

There is an issue (enhancement) with the igc-slider component where the aria-label attribute is applied to both the igc-slider and its inner thumb element. This is not correct because the aria-label should be applied only to the thumb, which is the focusable part of the slider. When navigating via keyboard (tabbing), users focus directly on the thumb and not the slider container itself.

Reproduction

To observe the issue:

1. Include an igc-slider component in your project.
2. Inspect the rendered HTML in the browser.
3. Notice that both the igc-slider and its inner thumb element have the aria-label attribute applied.

Workaround

I have not found a workaround.

Is this a regression?

No or unsure. This never worker, or I haven't tried before.

Affected versions

5.0.2

Browser/OS/Node environment

Browser: All modern browsers (e.g., Chrome, Firefox, Edge)
Operating System: All platforms (e.g., Windows, macOS, Linux)

@georgianastasov georgianastasov added bug Something isn't working 🆕 status: new The issue is new and will be reviewed when somebody picks it up. labels Sep 30, 2024
@simeonoff simeonoff assigned simeonoff and SisIvanova and unassigned simeonoff Oct 14, 2024
@SisIvanova SisIvanova added slider and removed 🆕 status: new The issue is new and will be reviewed when somebody picks it up. labels Oct 17, 2024
@simeonoff
Copy link
Collaborator

@SisIvanova we will have to defer this fix as after some discussion with @rkaraivanov, we would like to implement a different solution that will solve this and other issues in the component.

@simeonoff simeonoff reopened this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working slider
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants