Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure registry client with a map #165

Open
davidlivingrooms opened this issue Jan 22, 2024 · 2 comments
Open

Configure registry client with a map #165

davidlivingrooms opened this issue Jan 22, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@davidlivingrooms
Copy link

davidlivingrooms commented Jan 22, 2024

I'm trying to use this plugin with confluent cloud. We only support api key and secret authentication, but I don't believe this is supported by this library. I only see instructions for basic auth. Am I missing something or does this library not work with confluent cloud api secrets?

@ImFlog
Copy link
Owner

ImFlog commented Jan 22, 2024

Hello @davidlivingrooms,

I think you are right, this plugin does not currently support this mode of authentication.
It should be fairly simple to add : pass the right configuration to the Registry Client as we rely on it for the authentication, requests ...

But it will probably be hard to test. We could have unit test that verifies that the mock clients has the correct configuration but in a more interesting Integration test, I don't know if it's possible to spin a container with the correct configuration (I am not a customer of confluent cloud myself). Any idea are welcomed.

Would you like to throw a PR for this ? Happy to assist if needs be, I am a bit short on time currently so if you are in a hurry it might be better for you.

@ImFlog ImFlog added the enhancement New feature or request label Jan 22, 2024
@ImFlog ImFlog changed the title Support api key authentication Configure registry client with a map May 31, 2024
@ImFlog
Copy link
Owner

ImFlog commented May 31, 2024

This issue is now more to allow all the properties from the Confluent documentation to create the client. That will solve the original issue of the api-key as well as other things like bypassing SSL validation.
See https://docs.confluent.io/platform/current/schema-registry/installation/config.html#sr-configuration-reference-for-cp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants