Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The PModel constants are currently fixed. #697

Open
davidorme opened this issue Jan 24, 2025 · 0 comments
Open

The PModel constants are currently fixed. #697

davidorme opened this issue Jan 24, 2025 · 0 comments

Comments

@davidorme
Copy link
Collaborator

davidorme commented Jan 24, 2025

The PlantsModel uses pyrealm.pmodel.PModel, which takes arguments setting pmodel_consts and core_consts, which are instances of pyrealm.constants.PModelConst and pyrealm.constants.CoreConst. Most of these are very unlikely to change, but we do need to be able to change them. At the moment (over in branch #659 ), the implementation just has this fixed, but we will need a mechanism to update it.

That might most easily be a new entries in the PlantsConsts object allows an arbitrary dictionary that will get passed to PModelConst and CoreConst as kwargs.

Ultimately, we need to look at the overlap between the VE constants and these constants and synchronise them.

@davidorme davidorme added this to the Plant Model Development milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant