Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common agreements from the meeting for PR#50 before next release (Xiaoli, Tina, Martin) #54

Open
xiaoliz0 opened this issue Feb 12, 2025 · 0 comments

Comments

@xiaoliz0
Copy link
Contributor

  1. Rename the functions related to Excel from "read_exl" to "read_tsv", better understanding for currently data file type.
  2. Delete the variables are not in use in the scripts.
  3. Optimize codes related to "data_issue" in TSOPPI output files.
  4. All clinical information column assignments can be grouped in a dictionary, and then be accessed via columns['age'].
  5. Format strings in the script.
  6. Rename variable from "table_header_aliase" to "table_header_aliases".
  7. Rename "header_not_exist_InTable" to "header_not_exist_in_table".
  8. Function of adding table into the slide 8 in ppt report will cause errors for the previous old data due to missing 2 new added columns.
  9. Remove column Protein_change_(code) which is not in use currently from the script.
  10. Rename column "Genomic coordinates in hg19 build" in table to "Genomic_coordinates_in_hg19_build"? (confirm with biologist group)
  11. Extract all hard coding information from script to configure file. (To do later)
  12. Config file to be yaml format config file should be yaml format #52 (To do later)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant