Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit first line of the commit message to 72 characters #5254

Open
dzenanz opened this issue Feb 22, 2025 · 3 comments
Open

Limit first line of the commit message to 72 characters #5254

dzenanz opened this issue Feb 22, 2025 · 3 comments
Labels
type:Style Style changes: no logic impact (indentation, comments, naming)

Comments

@dzenanz
Copy link
Member

dzenanz commented Feb 22, 2025

Currently, a 78-character limit is enforced by pre-commit infrastructure. I think it would be good to reduce this to 72, to play better with GitHub's limit of 72, thus avoiding truncation of displayed PR messages.

@dzenanz dzenanz added the type:Style Style changes: no logic impact (indentation, comments, naming) label Feb 22, 2025
@thewtex
Copy link
Member

thewtex commented Feb 24, 2025

78 is already quite a challenge. While it would be nice to avoid wrapping in the pull request subject on GitHub, a tradeoff in preference of a meaningful message is better in my opinion.

@seanm
Copy link
Contributor

seanm commented Feb 24, 2025

78 is already quite a challenge. While it would be nice to avoid wrapping in the pull request subject on GitHub, a tradeoff in preference of a meaningful message is better in my opinion.

+1 for me. Especially with the prefix ITK requires, I often find myself writing contorted commit summaries due to the tiny length allowed.

@dzenanz
Copy link
Member Author

dzenanz commented Feb 24, 2025

There is also the rest of the commit message 😄, as @jhlegarreta frequently points out. The first line doesn't have to be fully descriptive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Style Style changes: no logic impact (indentation, comments, naming)
Projects
None yet
Development

No branches or pull requests

3 participants