Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using trigger="refresh" around a form prevents fields with keyboard to work correctly #907

Open
flochtililoch opened this issue Jul 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@flochtililoch
Copy link
Collaborator

flochtililoch commented Jul 24, 2024

This is visible when implementing custom components that allow interactions while the keyboard is open, such as auto-complete: the scroll view captures the tap and dismiss the keyboard instead of letting the custom component handle the tap.
This problem is already solved when explicit scroll="true" is added without the refresh trigger, as the underlying scrollview sees its keyboardShouldPersistTaps property being set correctly. However, with the scrollview automatically added with the refresh trigger, this property is not set (see code).
The problem is also likely the same with <list> and <section-list> elements, as we're not explicitly setting the prop in either of the underlying <List> / <SectionList> components (EDIT: we do now since #940).

Ideally, the logic that detects the presence of a form field and condition the property should be lifted in a common service, and shared between all these use cases of scrollable views.

Relates to https://app.asana.com/0/1173738217633521/1207872155407865/f

@flochtililoch flochtililoch added the bug Something isn't working label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant