Skip to content

Commit 2e25253

Browse files
Fixed typo in the code for set_default_queue (#117)
* Fixed typo in the code for set_default_queue Allowing both strings or enums as selectors for backend and device. * Fixed "variabel reference before assignment" in device_context manager ctxt must be set outside of try/finally to be guaranteed avaialble in the finally clause.
1 parent 49042af commit 2e25253

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

dpctl/sycl_core.pyx

+10-4
Original file line numberDiff line numberDiff line change
@@ -626,7 +626,7 @@ cdef class _SyclRTManager:
626626
def print_available_backends (self):
627627
""" Prints the available backends.
628628
"""
629-
print(self._backend_ty_dict.keys())
629+
print(self._backend_str_ty_dict.keys())
630630

631631
def get_current_backend (self):
632632
""" Returns the backend for the current queue as `backend_type` enum
@@ -719,9 +719,15 @@ cdef class _SyclRTManager:
719719
def set_default_queue (self, backend_ty, device_ty, device_id):
720720
cdef DPPLSyclQueueRef ret
721721
try :
722-
beTy = self._backend_ty_dict[backend_ty]
722+
if isinstance(backend_ty, str):
723+
beTy = self._backend_str_ty_dict[backend_ty]
724+
else:
725+
beTy = self._backend_enum_ty_dict[backend_ty]
723726
try :
724-
devTy = self._device_ty_dict[device_ty]
727+
if isinstance(device_ty, str):
728+
devTy = self._device_str_ty_dict[device_ty]
729+
else:
730+
devTyp = self._device_enum_ty_dist[device_ty]
725731
ret = DPPLQueueMgr_SetAsDefaultQueue(beTy, devTy, device_id)
726732
if ret is NULL:
727733
self._raise_queue_creation_error(
@@ -839,6 +845,7 @@ def device_context (str queue_str="opencl:gpu:0"):
839845
# calling get_current_context, or use the returned context object directly.
840846

841847
# If set_context is unable to create a new context an exception is raised.
848+
ctxt = None
842849
try:
843850
attrs = queue_str.split(':')
844851
nattrs = len(attrs)
@@ -849,7 +856,6 @@ def device_context (str queue_str="opencl:gpu:0"):
849856
"device_number defaults to 0")
850857
if nattrs == 2:
851858
attrs.append("0")
852-
ctxt = None
853859
ctxt = _mgr._set_as_current_queue(attrs[0], attrs[1], int(attrs[2]))
854860
yield ctxt
855861
finally:

0 commit comments

Comments
 (0)